Closed ndunningbmw closed 1 year ago
Hi @tbleher , hi Jakob Peintner,
would you also like to give a review on this PR?
Hi @tbleher , hi Jakob Peintner,
would you also like to give a review on this PR?
I think the initative is a good one :) I can only really talk about bounding boxes of static objects (which is what I'm currently looking at for the OSIPedestrian model): it's very good for e.g. pedestrian models if tree trunk and tree arm can be separated (and similarly light pole and light arm). However, I have two main concerns with the proposal right now:
So, speaking as someone creating agent models, it would be much more important to have the ability to segment an object such that one has the guarantee that some areas of the dimension are in fact free. For such use-cases, the exact type does not matter at all, and could be left out. Is there any user who cares about this (the type distinction) for static objects like trees and traffic lights? I can see how this is important for wheels vs mirrors and such, but not so much for crown vs trunk - I just want to have a better 3D approximation of the tree so the pedestrian can accurately walk around it.
#### Reference to a related issue in the repository Add a reference to a related issue in the repository.
Add a description
This PR proposes the addition of bounding box sub-sections to BaseMoving and BaseStationary objects, to help sub-divide and classify different parts of the overall object structure.
Some questions to ask: What is this change? What does it fix? Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version? How has it been tested?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why. If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!