search

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
267 stars 125 forks source link

Feature/tp/add polyline model #484 #688

Open 0815-code opened 1 year ago

0815-code commented 1 year ago

#### Reference to a related issue in the repository Add a reference to a related issue in the repository.

Add a description

Add a description of the changes proposed in the pull request.

Some questions to ask: What is this change? What does it fix? Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version? How has it been tested?

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

If you can’t check all of them, please explain why. If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

jdsika commented 1 year ago

This PR has commits regarding the build pipeline which would need to be removed. Als #666 had some changes regarding Antora?

ThomasNaderBMW commented 1 year ago

@ThomasSchloemicherAVL : Is this change still a requirement and needed?

0815-code commented 1 year ago

@ThomasNaderBMW yes please. @jdsika yes sorry, that was my mistake after a rebase.

thomassedlmayer commented 1 year ago

@ThomasSchloemicherAVL: Would you like to join the OSI Other Models Working Group (22nd of May; 9-10am) to present and discuss the intention and further proceeding for this PR in the group? Some weeks ago we still had some open questions/concerns but it could be merged for OSI 3.6 after some adaptions. Also, the build pipeline stuff should get fixed at some point.

0815-code commented 1 year ago

@ThomasSchloemicherAVL: Would you like to join the OSI Other Models Working Group (22nd of May; 9-10am) to present and discuss the intention and further proceeding for this PR in the group? Some weeks ago we still had some open questions/concerns but it could be merged for OSI 3.6 after some adaptions. Also, the build pipeline stuff should get fixed at some point.

@thomassedlmayer sorry for the late reply. Yes, please add me to that meeting..

ClemensLinnhoff commented 4 months ago

Is this still a valid PR? If yes, should it be included in v.3.7.0?

pmai commented 4 months ago

OSI 3.7.0 is closed for new features.