feat: New OSI message osi_route

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.

Other

267 stars 125 forks source link

feat: New OSI message osi_route #705

Closed FabianPfeufferCAP closed 7 months ago

FabianPfeufferCAP commented 1 year ago

Add a description

Added a new OSI message osi_route.proto to send a planned route to an agent or a device, such as a vehicle or navigation system. This route information can then be used to plan a path and traverse the road network.

Some questions to ask: What is this change?

A new OSI feature to provide agent models with more logical data to perform path planning.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

[x] My suggestion follows the style and contributors guidelines.
[x] I have taken care about the message documentation and the fields and enums documentation.
[x] I have done the DCO signoff.
[x] My changes generate no errors when passing CI tests.
[x] I have successfully implemented and tested my fix/feature locally.
[ ] Appropriate reviewer(s) are assigned.

tbleher commented 1 year ago

Thank you @FabianPfeufferCAP ! Looks good to me. @ThomasNaderBMW I think this PR should be discussed in the "Other Models" WG, since it uses logical lanes. First review in the Harmonization WG was generally favorable (though we did not do a detailed review of the patch, but we discussed the naming, general concept and placement within the OSI structures).

ThomasNaderBMW commented 1 year ago

Feedback WG Other Models:

Does it have to match with OpenScenario e.g. Follow Path Actions?
Is logical lanes really the best option, if yes explain the use case better/ make it clear in the description of the message. For what shall it be used and for what not? What about LEVEL3 Use Cases, is it e.g. kind of global strategy or is this use case excluded?
Is there a connection to SetLevel4to5

thomassedlmayer commented 1 year ago

WG Other Models (2023-05-08): Waiting for minor rework of PR (see comments by @ThomasNaderBMW). Ready for CCB after next Other Models WG meeting.

ThomasNaderBMW commented 1 year ago

WG Other Models, open questions:

Presentation in OpenScenario-Group necessary. Is there something similar planned?
Information of Way Points necessary? Instead or as add on?
Next step: Presentation in appropriate OSC-Group

pmai commented 7 months ago

CCB 2024-02-12: Merge as-is.

jdsika commented 4 months ago

I mention #804 here

ClemensLinnhoff commented 4 months ago

I created a separate PR to add rules to existing comments describing rules: #806