search

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
267 stars 125 forks source link

Workflow: Update Python and Actions + Black formatting Python files #756

Closed jdsika closed 7 months ago

jdsika commented 7 months ago
pmai commented 7 months ago

I have created a separate PR for non-python related build workflow changes, that also adds support for newer protobuf releases (upto current 25.x releases), leaving this PR for python-related changes to workflow and python code changes, if wanted.

The apt-get update dance should be dropped, since we should never depend on anything more specific from the base system.

I'm not a huge fan of the black reformatting (or usually any automatic reformattings), as it just seems to change one set of idiosynchracies for another, but whatever floats anyones boat (I think the code should be rewritten in places to make it clearer, something the reformatting really doesn't address).

pmai commented 7 months ago

I've refactored to built upon the other workflow enhancements, so once those are merged only the python-related changes will remain in this PR.

jdsika commented 7 months ago

I have created a separate PR for non-python related build workflow changes, that also adds support for newer protobuf releases (upto current 25.x releases), leaving this PR for python-related changes to workflow and python code changes, if wanted.

The apt-get update dance should be dropped, since we should never depend on anything more specific from the base system.

I'm not a huge fan of the black reformatting (or usually any automatic reformattings), as it just seems to change one set of idiosynchracies for another, but whatever floats anyones boat (I think the code should be rewritten in places to make it clearer, something the reformatting really doesn't address).

not that I disagree with your stance towards formatting but in our case this will be done the same way as in the osi-validation and if a lot of people work on something it is helping to provide a consistent visual.

pmai commented 7 months ago

CCB 2014-01-15: Merge as-is.

jdsika commented 4 months ago

Reviewed for v3.7.0