OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
267 stars 125 forks source link

Add orientation rate to PedestrianAttributes::Bone #769

Closed ClemensLinnhoff closed 6 months ago

ClemensLinnhoff commented 7 months ago

#### Reference to a related issue in the repository

747

Add a description

Add orientation rate to the bone class. The translatory velocity of the bones can be calculated with the orientation rate of the parent bones.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

pmai commented 7 months ago

CCB 2024-01-29: Should be reviewed by @Peintnerer and @thempen, especially if also velocity should be added, as there is no directly specified relationship between position changes and hierarchical orientation_rate since we have no specified kinematic model (positions and hence gaps between bones can vary over time depending on modeling approaches). Therefore it might be a good idea to include velocity to provide all of the information the internal model has to consumers. To be re-revied at next CCB.

ClemensLinnhoff commented 7 months ago

We thought about it again and came to the conclusion, that also adding the translatory velocity makes sense, mainly because the shoulders and legs are disconnected from the spine. So there can be independent translatory movement. And as you said, if positions and bone lengths can theoretically also vary over time, we definitely need it.

I added the velocity in the proto file as a suggestion.

pmai commented 6 months ago

CCB 2024-02-12: Decision merge as-is.

jdsika commented 4 months ago

reviewed for v3.7.0