search

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
267 stars 125 forks source link

Removal of the historical .txt trace file format and related scripts #777

Closed PhRosenberger closed 7 months ago

PhRosenberger commented 7 months ago

#### Reference to a related issue in the repository This PR fixes #760

Add a description

Add a description of the changes proposed in the pull request.

Some questions to ask: The historical .txt output format for hybrid binary/human readable OSI trace files does not really help anyone and was not used by the community so far. I therefore strongly propose to get rid of it and the related python script for conversion to the actually binary .osi format.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

thomassedlmayer commented 7 months ago

We should probably also remove the format choice of the osi2read argparser and the respective code in the OSITrace.py on the separated txt format.

PhRosenberger commented 7 months ago

We should probably also remove the format choice of the osi2read argparser and the respective code in the OSITrace.py on the separated txt format.

I just updated the PR accordingly. Could you please check / test it?

PhRosenberger commented 7 months ago

@pmai obviously, removing the format command line argument interfers with our current pypeline. Should we change the test of the python scripts in this PR, as well?

PhRosenberger commented 7 months ago

@pmai obviously, removing the format command line argument interfers with our current pypeline. Should we change the test of the python scripts in this PR, as well?

Ok, seems like, I just missed one line, pipeline has passed now. However, would appreciate some double-check here.

pmai commented 7 months ago

CCB 2024-02-26: Merge with suggested addition of historical note; thanks for the effort.

thomassedlmayer commented 7 months ago

Sorry for the late check. I found another format_type appearance in the file in the osi2read.py.