search

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
265 stars 124 forks source link

Modernize python build setup, protoc dependency #783

Closed pmai closed 3 months ago

pmai commented 4 months ago

This moves most meta-data to pyproject.toml, automates the version handling and makes it available at runtime, depends on protoc via the protoc-wheel-0 package, makes sdist and bdist distributions work correctly, and removes dependencies that are not build dependencies, but rather used only in CI.

ClemensLinnhoff commented 4 months ago

Unit tests need to be fixed. There seem to be some issues due to the renaming of the format folder, see pipeline run.

jdsika commented 4 months ago

Proto 3.6.1 in use for OSI-Validation at BMW

thomassedlmayer commented 4 months ago

@pmai In formatting_scripts.adoc there is a note that converted.txth is the default name of the output file. This should be changed as now the default name is the input file name.

jdsika commented 3 months ago

@pmai will this be ready to merge next CCB?

pmai commented 3 months ago

@pmai In formatting_scripts.adoc there is a note that converted.txth is the default name of the output file. This should be changed as now the default name is the input file name.

Yes, that was however already wrong prior to this PR, so I would suggest fixing in separate PR.

pmai commented 3 months ago

CCB 2025-03-25: Merge as-is.

jdsika commented 2 months ago

I was a bit confused about the diff at first but this was a mix of moving files and linter. so OK

Reviewed for v3.7.0