Closed thempen closed 6 months ago
The ruleset for enum definition "shall" is not useful in many cases where "UNKNOWN" and "OTHER" is more confusing than helpful. So it should only be a recommendation for future implmentations.
There are already multiple enums without the UNKNOWN and OTHER definition, like in https://github.com/OpenSimulationInterface/open-simulation-interface/blob/master/osi_motionrequest.proto. There are also current PRs where the current definition is appropriate.
The rule to add "UNKNOWN" and "OTHER" should only be a recommendation in the future.
@thempen
CCB 2024-03-11: Merge as-is.
The ruleset for enum definition "shall" is not useful in many cases where "UNKNOWN" and "OTHER" is more confusing than helpful. So it should only be a recommendation for future implmentations.
Reference to a related issue in the repository
There are already multiple enums without the UNKNOWN and OTHER definition, like in https://github.com/OpenSimulationInterface/open-simulation-interface/blob/master/osi_motionrequest.proto. There are also current PRs where the current definition is appropriate.
Add a description
The rule to add "UNKNOWN" and "OTHER" should only be a recommendation in the future.
Mention a member
@thempen
Check the checklist