OpenSimulationInterface / osi-validation

Tools around the OSI used to verify the content of messages and more.

Other

10 stars 8 forks source link

Update OSI submodule to version 3.6.0 #50

Closed ClemensLinnhoff closed 10 months ago

ClemensLinnhoff commented 10 months ago

Reference to a related issue in the repository

49

Add a description

Update OSI submodule to version 3.6.0

Mention a member

@vkresch @jdsika

Check the checklist

[x] My code and comments follow the contributors guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation for osi-validation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests / travis ci pass locally with my changes.

vkresch commented 10 months ago

Thanks for creating the PR but this needs to be checked with github actions pipeline implemented in https://github.com/OpenSimulationInterface/osi-validation/pull/48 before we can merge this. The default rules and protobuf version might also to be updated.

jdsika commented 10 months ago

I think the installation failure on windows in #48 is due to the old OSI. Can't we merge this branch into the other PR?

Update: I have created #54