search

OpenSimulationInterface / osi-visualizer

**This repository is abandoned and looking for a maintainer.** A tool to visualize OSI data from two different sources. Data can be stored in files and replayed afterwards, or validated using a Python interface.
Other
39 stars 25 forks source link

Integrate fmu, field of view, and better alignment of the GUI fields. #18

Closed Yang-Wu-Altran closed 6 years ago

Yang-Wu-Altran commented 6 years ago

@pmai @CarloVanDriestenBMW Sorry for this interrupt. There is small typo in the last Pull request. I remove it, and make this new one. @pmai Could you please take care of the FMI library inside CMakeLists.txt ? Thanks very much!!

ghost commented 6 years ago

@Yang-Wu-Altran you can just commit on an existing PR and you do not have to remove it all the time!

1) check out your branch locally 2) remove the typo (or anything else) 3) commit -m "fixed XYZ" 4) push

The changes will be visible for everyone.

ghost commented 6 years ago

The FMU should be integrated via dependency to the other repository!

pmai commented 6 years ago

This commit seems do undo all of the changes I made to get this running, esp. for Travis CI, hence the breakage. So please change the commit to not do this.

@CarloVanDriestenBMW There should be no fixed dependency on the FMU, so no direct linkage between Repos is needed IMHO: Any FMU that is a Sensor FMU should work...

Yang-Wu-Altran commented 6 years ago

@pmai Sorry for that. I am checking why it got undo all your changes. I think it's by accident.

pmai commented 6 years ago

The latest commit only seems to contain the makefile changes but not the include file breakage fixes (<osi/...> vs. „...“ which is the correct way).

Yang-Wu-Altran commented 6 years ago

@pmai Could you please take a look at the error? "HTTP request sent, awaiting response... 404 Not Found" . Can not find jmodelica.org/download/...

pmai commented 6 years ago

It seems that the FMI Library is no longer available anywhere on JModelica.org, and there seems to be no other place it is currently available from, so this breaks our CI... I'll see what I can do...

Yang-Wu-Altran commented 6 years ago

@pmai Thanks very much!

Yang-Wu-Altran commented 6 years ago

@pmai https://svn.jmodelica.org/FMILibrary/tags/ this place works.

ghost commented 6 years ago

@haoyuanying abandon this one?

haoyuanying commented 6 years ago

@CarloVanDriestenBMW yes