Closed tbleher closed 3 years ago
@pmai und @jdsika : Ich weiß nicht, ob jemand von euch Mails bekommt von Pull-Requests hier, daher kurz ein Mention, dass ihr den Pull Request seht.
I am in fact not subscribed :) thx for the mention
@pmai and @jdsika : what needs to be done to get this pull request to be merged? Can you do this, or is there some ASAM process?
Output CBB 28.04.2021:
TravisCI did not run because of sercurity reasons as described here: https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
Rebase for DCO is needed here. @ThomasNaderBMW
So after a rebase, the change is now built successfully. Who can merge this now?
Thank you @tbleher , too many topics as you know :/ I will care about the merge at the next CCB on 09.06.
Output CCB 09.06.2021:
Unfortunately CMAKE_AUTORCC does not properly add dependencies on the files included by the qrc file. This means that when a file changes that is included in the qrc file, the qrc file is not automatically rebuilt. This results in broken builds.
Fix this by building the qrc file directly (instead of relying on CMAKE_AUTORCC) and adding proper dependencies.
As a side cleanup, move the resources.qrc file to resources/, so the top-level directory is cleaner.
Reference to a related issue in the repository
Add a reference to a related issue in the repository.