OpenSimulationInterface / osi-visualizer

**This repository is abandoned and looking for a maintainer.** A tool to visualize OSI data from two different sources. Data can be stored in files and replayed afterwards, or validated using a Python interface.
Other
39 stars 25 forks source link

Properly rebuild resource file if shader changes (#53) #55

Closed tbleher closed 3 years ago

tbleher commented 3 years ago

Unfortunately CMAKE_AUTORCC does not properly add dependencies on the files included by the qrc file. This means that when a file changes that is included in the qrc file, the qrc file is not automatically rebuilt. This results in broken builds.

Fix this by building the qrc file directly (instead of relying on CMAKE_AUTORCC) and adding proper dependencies.

As a side cleanup, move the resources.qrc file to resources/, so the top-level directory is cleaner.

Reference to a related issue in the repository

Add a reference to a related issue in the repository.

tbleher commented 3 years ago

@pmai und @jdsika : Ich weiß nicht, ob jemand von euch Mails bekommt von Pull-Requests hier, daher kurz ein Mention, dass ihr den Pull Request seht.

jdsika commented 3 years ago

I am in fact not subscribed :) thx for the mention

tbleher commented 3 years ago

@pmai and @jdsika : what needs to be done to get this pull request to be merged? Can you do this, or is there some ASAM process?

kmeids commented 3 years ago

Output CBB 28.04.2021:

  1. @stefancyliax will check out why travis did not run on this merge request.
stefancyliax commented 3 years ago

TravisCI did not run because of sercurity reasons as described here: https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

Rebase for DCO is needed here. @ThomasNaderBMW

tbleher commented 3 years ago

So after a rebase, the change is now built successfully. Who can merge this now?

ThomasNaderBMW commented 3 years ago

Thank you @tbleher , too many topics as you know :/ I will care about the merge at the next CCB on 09.06.

kmeids commented 3 years ago

Output CCB 09.06.2021:

  1. Checked by @ThomasNaderBMW and can be merged him as well.