OpenSlides / openslides-autoupdate-service

Autoupdate service for OpenSlides 4+
MIT License
2 stars 21 forks source link

Unlimited reconnection attempts when user in `default`-group #243

Closed GabrielInTheWorld closed 3 years ago

GabrielInTheWorld commented 3 years ago

Signing in as a user in the default-group of one meeting (in a meeting) leads to unlimited reconnection attempts to the autoupdate-service. This has to be investigated.

FinnStutzenstein commented 3 years ago

Autoupdate service error:

Internal Error: get first time restricted data: restrict data: checker for key motion/1/comment_ids: check fqids: restrict for collection motion_comment: checking motion_comment/1/id: getting motion id: motion_comment_section/1/motion_id does not exist.

Request:

{
  "collection": "meeting",
  "ids": [
    1
  ],
  "fields": {
    "name": null,
    "description": null,
    "location": null,
    "conference_show": null,
    "conference_auto_connect": null,
    "conference_los_restriction": null,
    "conference_stream_url": null,
    "projector_countdown_warning_time": null,
    "projector_countdown_default_time": null,
    "enable_anonymous": null,
    "export_csv_separator": null,
    "export_csv_encoding": null,
    "export_pdf_pagenumber_alignment": null,
    "export_pdf_fontsize": null,
    "export_pdf_pagesize": null,
    "start_time": null,
    "end_time": null,
    "agenda_show_subtitles": null,
    "agenda_enable_numbering": null,
    "agenda_number_prefix": null,
    "agenda_numeral_system": null,
    "agenda_item_creation": null,
    "agenda_new_items_default_visibility": null,
    "agenda_show_internal_items_on_projector": null,
    "list_of_speakers_amount_last_on_projector": null,
    "list_of_speakers_amount_next_on_projector": null,
    "list_of_speakers_couple_countdown": null,
    "list_of_speakers_enable_point_of_order_speakers": null,
    "list_of_speakers_speaker_note_for_everyone": null,
    "list_of_speakers_show_amount_of_speakers_on_slide": null,
    "list_of_speakers_present_users_only": null,
    "list_of_speakers_show_first_contribution": null,
    "list_of_speakers_initially_closed": null,
    "list_of_speakers_enable_pro_contra_speech": null,
    "list_of_speakers_can_set_contribution_self": null,
    "motions_default_workflow_id": null,
    "motions_default_amendment_workflow_id": null,
    "motions_default_statute_amendment_workflow_id": null,
    "motions_preamble": null,
    "motions_default_line_numbering": null,
    "motions_line_length": null,
    "motions_reason_required": null,
    "motions_enable_text_on_projector": null,
    "motions_enable_reason_on_projector": null,
    "motions_enable_recommendation_on_projector": null,
    "motions_show_referring_motions": null,
    "motions_enable_sidebox_on_projector": null,
    "motions_show_sequential_number": null,
    "motions_recommendations_by": null,
    "motions_statute_recommendations_by": null,
    "motions_recommendation_text_mode": null,
    "motions_default_sorting": null,
    "motions_number_type": null,
    "motions_number_min_digits": null,
    "motions_number_with_blank": null,
    "motions_statutes_enabled": null,
    "motions_amendments_enabled": null,
    "motions_amendments_in_main_list": null,
    "motions_amendments_of_amendments": null,
    "motions_amendments_prefix": null,
    "motions_amendments_text_mode": null,
    "motions_amendments_multiple_paragraphs": null,
    "motions_supporters_min_amount": null,
    "motion_poll_default_type": null,
    "motion_poll_default_100_percent_base": null,
    "motion_poll_default_majority_method": null,
    "motion_poll_default_group_ids": null,
    "motion_poll_ballot_paper_selection": null,
    "motion_poll_ballot_paper_number": null,
    "motions_export_title": null,
    "motions_export_preamble": null,
    "motions_export_submitter_recommendation": null,
    "motions_export_follow_recommendation": null,
    "assignment_poll_default_method": null,
    "assignment_poll_default_type": null,
    "assignment_poll_default_100_percent_base": null,
    "assignment_poll_default_majority_method": null,
    "assignment_poll_default_group_ids": null,
    "assignment_poll_add_candidates_to_list_of_speakers": null,
    "assignment_poll_sort_poll_result_by_votes": null,
    "assignment_poll_ballot_paper_selection": null,
    "assignment_poll_ballot_paper_number": null,
    "assignments_export_title": null,
    "assignments_export_preamble": null,
    "users_sort_by": null,
    "users_enable_presence_view": null,
    "users_allow_self_set_present": null,
    "users_enable_vote_weight": null,
    "users_pdf_welcometitle": null,
    "users_pdf_welcometext": null,
    "users_pdf_url": null,
    "users_pdf_wlan_ssid": null,
    "users_pdf_wlan_password": null,
    "users_pdf_wlan_encryption": null,
    "users_email_sender": null,
    "users_email_replyto": null,
    "users_email_subject": null,
    "users_email_body": null,
    "custom_translations": null,
    "id": null,
    "logo_$_id": {
      "type": "template"
    },
    "font_$_id": {
      "type": "template"
    },
    "reference_projector_id": null,
    "default_group_id": {
      "type": "relation",
      "collection": "group",
      "fields": {
        "name": null,
        "permissions": null,
        "admin_group_for_meeting_id": null,
        "default_group_for_meeting_id": null,
        "id": null
      }
    },
    "admin_group_id": {
      "type": "relation",
      "collection": "group",
      "fields": {
        "name": null,
        "permissions": null,
        "admin_group_for_meeting_id": null,
        "default_group_for_meeting_id": null,
        "id": null
      }
    },
    "projector_ids": {
      "type": "relation-list",
      "collection": "projector",
      "fields": {
        "name": null,
        "scale": null,
        "scroll": null,
        "width": null,
        "aspect_ratio_numerator": null,
        "aspect_ratio_denominator": null,
        "color": null,
        "background_color": null,
        "header_background_color": null,
        "header_font_color": null,
        "header_h1_color": null,
        "chyron_background_color": null,
        "chyron_font_color": null,
        "show_header_footer": null,
        "show_title": null,
        "show_logo": null,
        "show_clock": null,
        "used_as_reference_projector_meeting_id": null,
        "id": null,
        "current_projection_ids": {
          "type": "relation-list",
          "collection": "projection",
          "fields": {
            "stable": null,
            "type": null,
            "options": null,
            "weight": null,
            "id": null,
            "content_object_id": {
              "type": "generic-relation",
              "fields": {
                "title": null,
                "number": null,
                "sequential_number": null,
                "text": null,
                "reason": null,
                "recommendation_id": null,
                "tag_ids": null,
                "personal_note_ids": null,
                "block_id": null,
                "category_id": null,
                "lead_motion_id": null,
                "comment_ids": null,
                "modified_final_version": null,
                "state_extension": null,
                "recommendation_extension": null,
                "agenda_item_id": null,
                "amendment_paragraph_$": {
                  "type": "template"
                },
                "poll_ids": null,
                "origin_id": null,
                "id": null,
                "is_directory": null,
                "parent_id": null,
                "child_ids": null,
                "mimetype": null,
                "filesize": null,
                "create_timestamp": null,
                "has_inherited_access_groups": null,
                "closed": null,
                "content_object_id": null,
                "speaker_ids": null,
                "internal": null,
                "open_posts": null,
                "phase": null,
                "candidate_ids": null,
                "description": null,
                "default_poll_description": null,
                "number_poll_candidates": null,
                "item_number": null,
                "comment": null,
                "type": null,
                "is_hidden": null,
                "is_internal": null,
                "duration": null,
                "weight": null,
                "level": null,
                "meeting_id": null,
                "first_name": null,
                "last_name": null,
                "username": null,
                "vote_weight_$": {
                  "type": "template"
                },
                "structure_level_$": {
                  "type": "template"
                },
                "number_$": {
                  "type": "template"
                },
                "email": null,
                "gender": null,
                "is_active": null,
                "is_physical_person": null,
                "is_present_in_meeting_ids": null,
                "last_email_send": null,
                "default_number": null,
                "default_structure_level": null,
                "default_vote_weight": null,
                "comment_$": {
                  "type": "template"
                },
                "about_me": null,
                "default_password": null,
                "entitled_group_ids": null,
                "state": null,
                "pollmethod": null,
                "voted_ids": null,
                "votescast": null,
                "votesinvalid": null,
                "votesvalid": null,
                "option_ids": null,
                "majority_method": null,
                "onehundred_percent_base": null,
                "global_option_id": null,
                "global_yes": null,
                "global_no": null,
                "global_abstain": null,
                "min_votes_amount": null,
                "max_votes_amount": null,
                "entitled_users_at_stop": null,
                "message": null,
                "default_time": null,
                "countdown_time": null,
                "running": null
              }
            }
          }
        },
        "preview_projection_ids": {
          "type": "relation-list",
          "collection": "projection",
          "fields": {
            "stable": null,
            "type": null,
            "options": null,
            "weight": null,
            "id": null,
            "content_object_id": {
              "type": "generic-relation",
              "fields": {
                "title": null,
                "number": null,
                "sequential_number": null,
                "text": null,
                "reason": null,
                "recommendation_id": null,
                "tag_ids": null,
                "personal_note_ids": null,
                "block_id": null,
                "category_id": null,
                "lead_motion_id": null,
                "comment_ids": null,
                "modified_final_version": null,
                "state_extension": null,
                "recommendation_extension": null,
                "agenda_item_id": null,
                "amendment_paragraph_$": {
                  "type": "template"
                },
                "poll_ids": null,
                "origin_id": null,
                "id": null,
                "is_directory": null,
                "parent_id": null,
                "child_ids": null,
                "mimetype": null,
                "filesize": null,
                "create_timestamp": null,
                "has_inherited_access_groups": null,
                "closed": null,
                "content_object_id": null,
                "speaker_ids": null,
                "internal": null,
                "open_posts": null,
                "phase": null,
                "candidate_ids": null,
                "description": null,
                "default_poll_description": null,
                "number_poll_candidates": null,
                "item_number": null,
                "comment": null,
                "type": null,
                "is_hidden": null,
                "is_internal": null,
                "duration": null,
                "weight": null,
                "level": null,
                "meeting_id": null,
                "first_name": null,
                "last_name": null,
                "username": null,
                "vote_weight_$": {
                  "type": "template"
                },
                "structure_level_$": {
                  "type": "template"
                },
                "number_$": {
                  "type": "template"
                },
                "email": null,
                "gender": null,
                "is_active": null,
                "is_physical_person": null,
                "is_present_in_meeting_ids": null,
                "last_email_send": null,
                "default_number": null,
                "default_structure_level": null,
                "default_vote_weight": null,
                "comment_$": {
                  "type": "template"
                },
                "about_me": null,
                "default_password": null,
                "entitled_group_ids": null,
                "state": null,
                "pollmethod": null,
                "voted_ids": null,
                "votescast": null,
                "votesinvalid": null,
                "votesvalid": null,
                "option_ids": null,
                "majority_method": null,
                "onehundred_percent_base": null,
                "global_option_id": null,
                "global_yes": null,
                "global_no": null,
                "global_abstain": null,
                "min_votes_amount": null,
                "max_votes_amount": null,
                "entitled_users_at_stop": null,
                "message": null,
                "default_time": null,
                "countdown_time": null,
                "running": null
              }
            }
          }
        }
      }
    },
    "poll_ids": {
      "type": "relation-list",
      "collection": "poll",
      "fields": {
        "entitled_group_ids": null,
        "state": null,
        "title": null,
        "type": null,
        "pollmethod": null,
        "content_object_id": {
          "type": "generic-relation",
          "fields": {
            "title": null,
            "number": null,
            "sequential_number": null,
            "text": null,
            "reason": null,
            "recommendation_id": null,
            "tag_ids": null,
            "personal_note_ids": null,
            "block_id": null,
            "category_id": null,
            "lead_motion_id": null,
            "comment_ids": null,
            "modified_final_version": null,
            "state_extension": null,
            "recommendation_extension": null,
            "agenda_item_id": null,
            "amendment_paragraph_$": {
              "type": "template"
            },
            "poll_ids": null,
            "origin_id": null,
            "id": null,
            "open_posts": null,
            "phase": null,
            "candidate_ids": null,
            "description": null,
            "default_poll_description": null,
            "number_poll_candidates": null
          }
        },
        "id": null
      }
    },
    "default_projector_$_id": {
      "type": "template",
      "values": {
        "type": "relation",
        "collection": "projector",
        "fields": {
          "name": null,
          "scale": null,
          "scroll": null,
          "width": null,
          "aspect_ratio_numerator": null,
          "aspect_ratio_denominator": null,
          "color": null,
          "background_color": null,
          "header_background_color": null,
          "header_font_color": null,
          "header_h1_color": null,
          "chyron_background_color": null,
          "chyron_font_color": null,
          "show_header_footer": null,
          "show_title": null,
          "show_logo": null,
          "show_clock": null,
          "used_as_reference_projector_meeting_id": null,
          "id": null
        }
      }
    }
  }
}
ostcar commented 3 years ago

The error message says, that the field motion_comment_section/1/motion_id does not exist. I also can not find this field in the models.yml or example data

https://github.com/OpenSlides/OpenSlides/blob/610a10712d1194fd56387da07fbc2bac924479b7/docs/example-data.json#L1572

https://github.com/OpenSlides/OpenSlides/blob/610a10712d1194fd56387da07fbc2bac924479b7/docs/models.yml#L1443

Did the models.yml change? Did you inform me? I thought we agreed that a pr that changes the models.yml has to wait until all maintainer changed there services and approved the change.

FinnStutzenstein commented 3 years ago

No, this field never existed before since comment sections do not directly link to motions at all.

ostcar commented 3 years ago

Ok. I fixed this issue in the autoupdate-service.

But maybe you should also change the client. If there is a 500er on the server and the client will try to reconnect constantly, then it would ddos the server.

Maybe retry 3 times, and once more after a minute but then stop with an error message viable to the user.