search

OpenSlides / openslides-autoupdate-service

Autoupdate service for OpenSlides 4+
MIT License
2 stars 21 forks source link

OpenTelemetry #401

Open ostcar opened 2 years ago

ostcar commented 2 years ago

Instrument service for OpenTelemetry.

ostcar commented 1 year ago

@ostcar how much work would it be to update this PR? it would be nice to have OTel availble in the autoupdate service, especially for debugging things like the current poll.stop performance

Originally posted by @jsangmeister in https://github.com/OpenSlides/openslides-autoupdate-service/issues/397#issuecomment-1719155114

I can look into this. One important requirement is, that the datastore-writer writes the trace-id into the messagebus. This is needed to create a relation between the backend-action-request and the autoupdate-events.

In my previous PR, I wrote a "key" span in the messagebus: https://github.com/OpenSlides/openslides-autoupdate-service/pull/397/files#diff-bc85461a4330bf9a7f24943c17dea0b71e26621b9e3e57ed8b2f8f5d1d115e24R172-R191

Does the datastore-writer currently add the span? If yes, what is the key and the format?

jsangmeister commented 1 year ago

I remembered implementing this in https://github.com/OpenSlides/openslides-datastore-service/pull/179, but it seems like @peb-adr removed the functionality again before merging. @peb-adr do you remember why? Otherwise, I would like to re-introduce this feature as previously implemented in the PR.

jsangmeister commented 1 year ago

Datastore issue: https://github.com/OpenSlides/openslides-datastore-service/issues/260

jsangmeister commented 11 months ago

@ostcar see notes in https://github.com/OpenSlides/openslides-datastore-service/pull/288