OpenSlides / openslides-backend

Backend service for OpenSlides 4+
MIT License
6 stars 26 forks source link

An archived meeting cannot be deleted #1175

Closed GabrielInTheWorld closed 2 years ago

GabrielInTheWorld commented 2 years ago

If I try to delete an archived meeting, this error message came up:

Meetings 3 cannot be changed, because they are archived.
reiterl commented 2 years ago

Yes, it is a feature, archived meetings can only be changed by superadmins.

reiterl commented 2 years ago

hmm, I chatted with @r-peschke about this issue, he said, that archived meetings should be deletable.

reiterl commented 2 years ago

Can you add the relations of the archived meeting/3? A single relation-less meeting can be deleted, even if it is archived.

reiterl commented 2 years ago

I tested a meeting with a motion, a topic and a group/user in it. This archived meeting could be deleted.

GabrielInTheWorld commented 2 years ago

Can you add the relations of the archived meeting/3? A single relation-less meeting can be deleted, even if it is archived.

{
  "id":3,
  "name":"Pok\u00e9monwelt (1) - Copy",
  "tag_ids":[

  ],
  "end_time":1643151600,
  "location":"",
  "poll_ids":[

  ],
  "user_ids":[
    1
  ],
  "vote_ids":[

  ],
  "group_ids":[
    13,
    14,
    15,
    11,
    12
  ],
  "topic_ids":[
    10
  ],
  "motion_ids":[

  ],
  "option_ids":[

  ],
  "start_time":1643151600,
  "description":"",
  "imported_at":1643289111,
  "speaker_ids":[

  ],
  "committee_id":2,
  "meta_deleted":false,
  "welcome_text":"<p>Space for your welcome text.</p>",
  "applause_type":"applause-type-bar",
  "mediafile_ids":[

  ],
  "meta_position":150,
  "projector_ids":[
    4
  ],
  "users_pdf_url":"https://example.com",
  "users_sort_by":"first_name",
  "welcome_title":"Welcome to OpenSlides",
  "admin_group_id":14,
  "assignment_ids":[

  ],
  "chat_group_ids":[

  ],
  "projection_ids":[

  ],
  "agenda_item_ids":[
    17
  ],
  "applause_enable":false,
  "conference_show":false,
  "applause_timeout":5,
  "chat_message_ids":[

  ],
  "default_group_id":13,
  "enable_anonymous":false,
  "motion_block_ids":[

  ],
  "motion_state_ids":[
    34,
    32,
    31,
    33,
    35,
    37,
    45,
    41,
    38,
    42,
    40,
    39,
    43,
    44,
    36
  ],
  "motions_preamble":"The assembly may decide:",
  "users_email_body":"Dear {name},\n\nthis is your personal OpenSlides login:\n\n{url}\nUsername: {username}\nPassword: {password}\n\n\nThis email was generated automatically.",
  "personal_note_ids":[

  ],
  "poll_countdown_id":6,
  "poll_default_type":"analog",
  "all_projection_ids":[

  ],
  "motion_comment_ids":[

  ],
  "users_email_sender":"OpenSlides",
  "applause_max_amount":0,
  "applause_min_amount":1,
  "applause_show_level":false,
  "export_csv_encoding":"utf-8",
  "export_pdf_fontsize":10,
  "export_pdf_pagesize":"A4",
  "motion_category_ids":[

  ],
  "motion_workflow_ids":[
    5,
    6
  ],
  "motions_line_length":85,
  "motions_number_type":"per_category",
  "users_email_subject":"OpenSlides access data",
  "agenda_item_creation":"default_no",
  "export_csv_separator":",",
  "list_of_speakers_ids":[
    20
  ],
  "motion_submitter_ids":[

  ],
  "motions_export_title":"Motions",
  "organization_tag_ids":[

  ],
  "poll_default_backend":"fast",
  "agenda_numeral_system":"arabic",
  "agenda_show_subtitles":false,
  "conference_open_video":false,
  "poll_couple_countdown":true,
  "projector_message_ids":[

  ],
  "users_pdf_welcometext":"[Place for your welcome and help text.]",
  "default_projector_$_id":[
    "agenda_all_items",
    "topics",
    "list_of_speakers",
    "current_list_of_speakers",
    "motion",
    "amendment",
    "motion_block",
    "assignment",
    "user",
    "mediafile",
    "projector_message",
    "projector_countdowns",
    "assignment_poll",
    "motion_poll",
    "poll"
  ],
  "poll_default_group_ids":[

  ],
  "reference_projector_id":4,
  "users_pdf_welcometitle":"Welcome to OpenSlides",
  "agenda_enable_numbering":true,
  "conference_auto_connect":false,
  "motions_default_sorting":"number",
  "motions_reason_required":false,
  "projector_countdown_ids":[
    5,
    6
  ],
  "assignment_candidate_ids":[

  ],
  "assignments_export_title":"Elections",
  "motion_poll_default_type":"pseudoanonymous",
  "motions_statutes_enabled":false,
  "users_enable_vote_weight":false,
  "motions_amendments_prefix":"-\u00c4",
  "motions_number_min_digits":2,
  "motions_number_with_blank":false,
  "conference_enable_helpdesk":false,
  "conference_los_restriction":true,
  "conference_open_microphone":false,
  "default_projector_$poll_id":4,
  "default_projector_$user_id":4,
  "motion_comment_section_ids":[

  ],
  "motions_amendments_enabled":true,
  "users_enable_presence_view":false,
  "motion_poll_default_backend":"fast",
  "motions_default_workflow_id":5,
  "assignment_poll_default_type":"pseudoanonymous",
  "default_projector_$motion_id":4,
  "default_projector_$topics_id":4,
  "motion_statute_paragraph_ids":[

  ],
  "motions_amendments_text_mode":"paragraph",
  "users_allow_self_set_present":true,
  "list_of_speakers_countdown_id":5,
  "motion_poll_default_group_ids":[
    15
  ],
  "motions_supporters_min_amount":0,
  "poll_default_100_percent_base":"YNA",
  "assignment_poll_default_method":"Y",
  "motions_default_line_numbering":"outside",
  "motions_show_referring_motions":true,
  "motions_show_sequential_number":true,
  "assignment_poll_default_backend":"fast",
  "default_projector_$amendment_id":4,
  "default_projector_$mediafile_id":4,
  "export_pdf_pagenumber_alignment":"center",
  "motion_poll_ballot_paper_number":8,
  "motions_amendments_in_main_list":true,
  "default_projector_$assignment_id":4,
  "motion_change_recommendation_ids":[

  ],
  "motions_amendments_of_amendments":false,
  "motions_enable_text_on_projector":true,
  "motions_recommendation_text_mode":"diff",
  "projector_countdown_default_time":60,
  "projector_countdown_warning_time":0,
  "assignment_poll_default_group_ids":[
    15
  ],
  "default_projector_$motion_poll_id":4,
  "list_of_speakers_couple_countdown":true,
  "list_of_speakers_initially_closed":false,
  "default_projector_$motion_block_id":4,
  "motion_poll_ballot_paper_selection":"CUSTOM_NUMBER",
  "motions_enable_reason_on_projector":false,
  "agenda_new_items_default_visibility":"internal",
  "assignment_poll_ballot_paper_number":8,
  "list_of_speakers_present_users_only":false,
  "motions_enable_sidebox_on_projector":false,
  "motion_poll_default_100_percent_base":"YNA",
  "motions_export_follow_recommendation":false,
  "conference_auto_connect_next_speakers":0,
  "default_projector_$assignment_poll_id":4,
  "motions_default_amendment_workflow_id":5,
  "assignment_poll_ballot_paper_selection":"CUSTOM_NUMBER",
  "default_projector_$agenda_all_items_id":4,
  "default_projector_$list_of_speakers_id":4,
  "motions_amendments_multiple_paragraphs":true,
  "agenda_show_internal_items_on_projector":true,
  "default_projector_$projector_message_id":4,
  "motions_export_submitter_recommendation":true,
  "assignment_poll_default_100_percent_base":"valid",
  "list_of_speakers_show_first_contribution":false,
  "assignment_poll_sort_poll_result_by_votes":true,
  "list_of_speakers_amount_last_on_projector":0,
  "list_of_speakers_amount_next_on_projector":-1,
  "list_of_speakers_enable_pro_contra_speech":false,
  "default_projector_$projector_countdowns_id":4,
  "list_of_speakers_can_set_contribution_self":false,
  "list_of_speakers_speaker_note_for_everyone":true,
  "motions_enable_recommendation_on_projector":true,
  "motions_default_statute_amendment_workflow_id":5,
  "default_projector_$current_list_of_speakers_id":4,
  "list_of_speakers_enable_point_of_order_speakers":true,
  "list_of_speakers_show_amount_of_speakers_on_slide":true,
  "assignment_poll_add_candidates_to_list_of_speakers":false
}
reiterl commented 2 years ago

Add a failing test in PR https://github.com/OpenSlides/openslides-backend/pull/1186 This test reproduces the error.