OpenSlides / openslides-client

Webclient for OpenSlides 4+
MIT License
3 stars 33 forks source link

Replace libraries that use ViewEngine #2345

Closed bastianjoel closed 1 year ago

bastianjoel commented 1 year ago

ViewEngine libraries are deprecated with angular 16. To make an update easier we should update or replace libraries that currently use it.

The following libraries are affected:

Timepicker replacement:

Extract marker: This library is so small that we should just implement its functionality ourselves in a helper function.

bastianjoel commented 1 year ago

There is a new fork of ngx-translate-extract which seems to be maintained here.

I would suggest merging our changes from https://github.com/OpenSlides/ngx-translate-extract to that fork and switching the dependency source.

jsangmeister commented 1 year ago

Sure, sounds good. Although we will have to rebase our changes everytime the base changes. We could try to create a PR to the fork and see if the changes are useful for other users as well, but IIRC at least some if it was relatively specific to our code.

bastianjoel commented 1 year ago

PR created https://github.com/vendure-ecommerce/ngx-translate-extract/pull/21