amendments: change recommendation diff doesn't work

[MSoeb]

Description: Recommendations with crossed out lines done in amendments are not displayed. The line will just disappear without a diff-hint. This isn't optimal. It is not easy to recognize, what content is crossed out.

Original amendment:

Crossed out sentence:

Reproduction:

1. open a meeting
2. open motions
3. create a motion
4. add an amendment to the motion
5. add a change recommendation to the amendment content by deleting a word or more content.

What should happen: The diff should display in the amendment the crossed out line done by the change recommendation. With this change users could easily spot diffs. Also the diff would be visible in the projection.

Note: The issue is linked to #2503

[CatoTH]

I could unfortunately not really replicate this right away... in the diff view, the striked out text appeared striked out, as in the screenshot. It was not really recognizable that this has changed in comparison to the original amendment, but it was striked out. Is there something particular to take into consideration when creating the change recommendation to trigger this?

[bastianjoel]

I think it is important that something was added to the end of a paragraph of the amendment.

So for example with motion text:

<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque eu, pretium quis, sem. Nulla consequat massa quis enim.</p>
<p>Donec pede justo, fringilla vel, aliquet nec, vulputate eget, arcu. In enim justo, rhoncus ut, imperdiet a, venenatis vitae, justo. Nullam dictum felis eu pede mollis pretium. Integer tincidunt. Cras dapibus. Vivamus elementum semper nisi. Aenean vulputate eleifend tellus.</p>

Create amendment for lines 1-4 and add text to the end. Now within the amendment create a change recommendation which removes a part from the beginning of the added text.

[jsangmeister]

@CatoTH do you work on this actively or should @bastianjoel continue to investigate this?

[CatoTH]

Hi, so I couldn't really reproduce it; so if you could narrow it down (or fix it, of course), that would be helpful.

[bastianjoel]

I think in the diff and changed version the changes from the amendment to the parent motion should not be displayed. I suggest changing that and adding final version which contains what currently is displayed in changed version to amendments. @emanuelschuetze @rrenkert what is your opinion on that?

[MSoeb]

Re-test: Tried it again with the newest version. The problem still occurs in the above described way. To clarify: Strike out means deletion in the context above. Sorry, if this was not exact enough. I edited this above

[bastianjoel]

I think in the diff and changed version the changes from the amendment to the parent motion should not be displayed. I suggest changing that and adding final version which contains what currently is displayed in changed version to amendments. @emanuelschuetze @rrenkert what is your opinion on that?

I suppose I was not clear enough here. This is less of a bug but more a flaw in what modes are available to view a amendments CRs.

[MSoeb]

We've discussed two possible solutions for this issue. I will add more detail on this, if we have a final solution.