OpenSlides / openslides-client

Webclient for OpenSlides 4+
MIT License
3 stars 31 forks source link

Amendment-detail fix change recommendation #2946

Open Elblinator opened 10 months ago

Elblinator commented 10 months ago

Current behaviour: In Amendment-detail view (you need an amendment which changes more than one line)

Descriptions changed because Case C and D are resolved and A/B needed a rework.

Reproduction: In a meeting:

  1. create a motion with several lines/paragraphs (I recommend 7 lines)
  2. create an amendment which changes several (but not all) lines in the motion
  3. add a change recommendation to the amendment 3.1. hover around the beginning of the sentence (a bit more to the left) until you find a blue cross-icon 3.2. press the icon 3.3. change something in the sentence and save (hint: doesn't matter, if it is a part of the change recommendation or the regular text.)
  4. ( Case A) ) now the original version of the amendment is active, not the Diff Version (compare: in a motion the Diff Version is active after adding a change recommendation.)
  5. (Case B) Original version must be active.- Open the console. Now activate the checkbox "Show entire motion text". An Error message appears in the console. The entire motion is not displayed. -> Reload the page to switch back to a working version.
  6. (Case B.1) Delete the change recommendation. -> CR stays active and visible. By deleting it twice, a correct error message appears.
  7. reload the page -> the change recommedantion is gone

Wanted behaviour:

Elblinator commented 10 months ago

Case D) only happens if the Diff Version is selected. @emanuelschuetze @MSoeb is this a feature?

If it is, ignore D)

Elblinator commented 10 months ago

Case C is solved by #2970

Elblinator commented 10 months ago

Case D) is wanted behaviour

MSoeb commented 8 months ago

Re-Tested and rewrited the issue:

reiterl commented 7 months ago

I looked into Case A: I can reproduce a failure there. In the os-motion-highlight-form the function determineCrMode doesn't work in this case. It sets the cr mode to original in a if clause, which shouldn't happen. The hasChangeRecommendation property returns a false, but it should return a true. I need more time to debug this.

reiterl commented 7 months ago

Add some fixes. I debugged here a lot, but there are still some issues here. I stop working on this. Case A and part of B1 should be fixed.

MSoeb commented 3 weeks ago

Re-Test: Case A) still occurs Case B) CR deletion -> still occurs Case B.1) can't reproduce it. seems to work correctly

bastianjoel commented 3 weeks ago

Very likely to be resolved after #4023 is finished.