OpenSlides / openslides-client

Webclient for OpenSlides 4+
MIT License
3 stars 29 forks source link

[Meta] Motion Forward: motion identifier not shown and Error thrown in console #3605

Open MSoeb opened 2 months ago

MSoeb commented 2 months ago

Description: When opening a forwarded motion from the original motion, the motion identifier is displayed incorrectly in the target event. Instead of "Motion 03", for example, "Motion not found" is displayed.

At the same time, an error message appears in the console. I cannot say whether this is the cause or whether another error is occurring at the same time.

target meeting with wrong motion identifier: image

error message after forwarding: image

Reproduction:

  1. Activate motion forwarding in two committees and create a meeting in each one
  2. open console to see Error when it is thrown
  3. open meeting A
  4. open motions > workflow > > complex workflow > allow forwarding in state approved
  5. open motions > create a motion with workflow complex and as submitter "Test".
  6. change status of the motion to approved and forward the motion to meeting B
  7. now open the target meeting by clicking on "Motion forwarded to" link
  8. Error is thrown and title is wrong

What should happen:

Elblinator commented 2 months ago

If I click on the link to move to the origin/forwarded meeting then I can reproduce the Error

I can not reproduce the first bug

I'll make a Meta Issue out of this and edit the description accordingly

reiterl commented 2 months ago

After the steps clicking on forward/origin shows the "not found" in Motion header. I don't see an error here.

reiterl commented 2 months ago

The motion-detail header needs a motion.number. I looked at the two subscriptions, MOTION_ADDITIONAL_DETAIL_SUBSCRIPTION and MOTION_DETAIL_SUBSCRIPTION. They both don't include the number field. But adding it here doesn't solve the problem. Mmh.

I see sometimes an motion is null error. This happens, if motion-meta-data getSubscriptions no motion is found for the motion.id. I can suppress the error with a filter not null. But I think, sth is broken here.

reiterl commented 2 months ago

Stop here for now.

Elblinator commented 1 month ago

I cannot reproduce the 'Motion not found' part Please clarify the reproduction

MSoeb commented 1 month ago

I've tried to reproduce it, but it works fine in the current OS version 4.1.9.

Because of this, I've changed the issue text. The issue can now be closed after the second part of it is fixed and merged.

Elblinator commented 3 weeks ago

The first bug from the meta issue is still relevant I could reproduce it once I forwarded the motion and navigated vis the link to the forwarded motion white fast (maybe something was still loading)

MSoeb commented 3 weeks ago

I agree with you. Tried it again. I can reproduce it with one motion in our test environment, but it doesn't occur with every motion. Not sure, what exactly caused the title loading bug.