OpenSlides / openslides-client

Webclient for OpenSlides 4+
MIT License
3 stars 32 forks source link

Fix projected timers #3678

Closed Elblinator closed 2 months ago

Elblinator commented 4 months ago

Current behaviour:

Reproduction:

  1. in the projector-list edit your projector
  2. activate "show clock", DEACTIVATE "show header and footer" and change the background colour to a colour where you can see the clock
  3. navigate to projector-detail view
  4. create three timers with 1:30 minutes, 2 min and zero minutes
  5. project two as fullscreen and display type "in Time and traffic light"
  6. the timers are overlapping (see screenshot)
  7. open the projection dialog of either of the timers
  8. the dialog saved on which projector the timer is projected but it does not save if it's fullscreen or the display type
  9. project the third timer as not fullscreen
  10. the timer overlaps with the clock (see screenshot)

Screenshot: Screenshot_20240516_083700

Wanted behaviour:

reiterl commented 3 months ago

I tried to reproduce this and have a question. I am in the projector detail view and add a timer. How can I project it as full screen?

Elblinator commented 3 months ago

when you see the timer right next to the timer-title you can see the icon 'open_in_new' pressing this icon will open the dialog where you can select the Display type

reiterl commented 2 months ago

Ah, yes, I can reproduce the overlapping times in 'Fullscreen'. It seems like that in the 'Default projector' the dialog is not filled fully.

reiterl commented 2 months ago

I have looked at it. The dialog seems to be a 'ProjectionDialogService' dialog. This is generic code, I could include code to check for fullsceen and default countdown in 'openProjectDialogFor()'. But it feels not right, because it would mix levels of concerns.

bastianjoel commented 2 months ago

It might make sense to do a refactoring of how the countdowns are displayed on the projector. When doing this #2940 could also be taken into account.

bastianjoel commented 2 months ago

Saving options is not possible with the projection dialog as the options (although not possible with current UI) might differ between projectors.

I would suggest removing the projector selection from the dialog. That way we would also enable users to project different timers with different layouts across projectors.

This would make #3934 obsolete.

bastianjoel commented 2 months ago

For now I will implement this as described in the previous comment.