search

OpenSlides / openslides-client

Webclient for OpenSlides 4+
MIT License
3 stars 33 forks source link

Fix wrong settings updates #3779

Open Elblinator opened 4 months ago

Elblinator commented 4 months ago

Current behaviour: If a sub setting is changed but the main setting is disabled then the changed values from the subsetting is not saved (or send in the send request)

Reproduction:

  1. In a meeting navigate to settings > participants
  2. open console
  3. Activate vote delegation
  4. Save change
  5. Activate the other delegation settings AND deactivate vote delegation
  6. Save changes
  7. look in the console: only users_enable_vote_delegations is updated
  8. Reload page, the subsettings are not updated

Wanted behaviour: The subsettings should be updated/saved even if the mainsetting is disabled

reiterl commented 4 months ago

I checked it, It works as expected. Greyout options are not saved. @Elblinator what is your problem with this behaviour? Why is this a "bug"?

Elblinator commented 4 months ago

My problem is that it is not expected behaviour in my opinion. If both settings are activated (main- and sub-setting) and then I deactivate the subsetting and then the main setting and then save (plus reload page) then I would expect the subsetting to be deactivated as well but in this scenario is is still activated

reiterl commented 4 months ago

No idea how to fix that.