search

OpenSlides / openslides-manage-service

Manage service for OpenSlides 4+
MIT License
4 stars 12 forks source link

Use of a second terminal is not required #191

Closed bkmgit closed 1 year ago

normanjaeckel commented 2 years ago

Hi @bkmgit . Thank you very much for your contribution. Hope you enjoy using OpenSlides.

To your pull request in detail: I propose NOT to merge it. Of course it is not necessary to run a second terminal because Docker compose can be used in daemonzied mode. But in this mode one can not see when all services are available. We do not have a nice signal system or anything else to determine whether OpenSlides is up and ready to receive the initial-data command (only a trial an error approach with timeout which can be annoying for first time users). We also can not display a progress bar. So I propose that we recommend two terminals for newbies in the README. Everybody with more experience can of course use the daemonized mode.

What do you think?

funkyfuture commented 1 year ago

but if someone with less of "more experience" quits the terminal session where the services were started in foreground, s/he would experience a stopped instance anyway, wouldn't s/he?

bkmgit commented 1 year ago

At least for me, it was ok. I would just check the website it is meant to be deployed on. Possibly adding some information about -d option is helpful since many people will likely log out of the terminal session. However, it is not essential.