OpenSlides / openslides-meta

MIT License
0 stars 12 forks source link

use python-sql instead of psycopg.sql for generating sql-queries #83

Closed r-peschke closed 7 months ago

r-peschke commented 7 months ago

It would've been nice if you'd have separated the commits into one single "cleanup" commit and one commit with actual changes. This way, it is really hard to review.

Apart from that, I don't see many changes which are not simple reformattings. I noticed that there are still many usages of psycopg.sql in dev/tests/base.py, is this intended or do you plan to clean that up as well?

It is intended to use some psycopg.sql, because python-sql has some limitations:

IMO python-sql is helpful to write the usual dml-sql, for special cases we need the (harder) psycopg.sql