search

OpenSmalltalk / opensmalltalk-vm

Cross-platform virtual machine for Squeak, Pharo, Cuis, and Newspeak.
http://opensmalltalk.org/
Other
557 stars 111 forks source link

Fix gdi leak #658

Closed nicolas-cellier-aka-nice closed 1 year ago

nicolas-cellier-aka-nice commented 1 year ago

On some win32 configurations and/or with some specific image, we observe a GDI leak : numbers of GDI objects rapidly grow up to 10,000 (about 50 new objects/second). when the limit is reached, the image hangs and we have to kill it...

With those fixes, the number of GDI objects remains stable at 20.

marceltaeumel commented 1 year ago

While I could not reproduce this issue on my system, I just verified that these changes do not change it for the worse. 😄 Works! Thank you.

nicolas-cellier-aka-nice commented 1 year ago

I think that we can trigger the Bug by forcing usage of a CursorWithAlpha, maybe thru:

Cursor useBiggerCursors: true.

or

2000 timesRepeat:
    [CursorWithAlpha biggerNormal show.
    Project current world doOneCycle.
    20 milliSeconds wait].

(BTW, I hate milliSeconds and would prefer milliseconds as it is a single word)

marceltaeumel commented 1 year ago

I think that we can trigger the Bug by forcing usage of a CursorWithAlpha, maybe thru:

Nope. Does not show on my machine. Stable at 20 GDI objects.

eliotmiranda commented 1 year ago

Thanks Nicolas!!

,,,^..^,,, (phone)

On Nov 14, 2022, at 12:17 PM, Nicolas Cellier @.***> wrote:

 Merged #658 into Cog.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.