search

OpenSmalltalk / opensmalltalk-vm

Cross-platform virtual machine for Squeak, Pharo, Cuis, and Newspeak.
http://opensmalltalk.org/
Other
557 stars 111 forks source link

config.h is included too late on Linux #659

Closed edoneel closed 1 year ago

edoneel commented 1 year ago

Hi,

We get the following errors on the automatic builds as of this commit

https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5a9222cd164d368885105edb95c7a29eab08081c

It is very consistant on Linux x86-64 and Linux Arm 32/64 builds.

Windows builds are ok.

cheers bruce

libtool: compile: gcc -Wall -march=armv8-a -mtune=cortex-a72 -g3 -O1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -DDEBUGVM=0 -DCOGMTVM=0 -DDUAL_MAPPED_CODE_ZONE=1 -pthread -DLSB_FIRST=1 -Wno-missing-braces -Wno-unknown-pragmas -Wno-unused-value -Wno-unused-label -Wno-unused-function -Wno-unused-variable -Wno-unused-but-set-variable -DHAVE_CONFIG_H -I/home/runner/work/opensmalltalk-vm/opensmalltalk-vm/building/linux64ARMv8/squeak.cog.spur/build.assert -I/home/runner/work/opensmalltalk-vm/opensmalltalk-vm/building/linux64ARMv8/squeak.cog.spur/build.assert -I/home/runner/work/opensmalltalk-vm/opensmalltalk-vm/platforms/unix/vm -I/home/runner/work/opensmalltalk-vm/opensmalltalk-vm/platforms/Cross/vm -I/home/runner/work/opensmalltalk-vm/opensmalltalk-vm/src/spur64.cog -I/usr/local/include -I/home/runner/work/opensmalltalk-vm/opensmalltalk-vm/platforms/Cross/plugins/SqueakFFIPrims -Wno-missing-braces -Wno-unknown-pragmas -Wno-unused-value -Wno-unused-label -Wno-unused-function -Wno-unused-variable -Wno-unused-but-set-variable -c /home/runner/work/opensmalltalk-vm/opensmalltalk-vm/platforms/Cross/plugins/SqueakFFIPrims/sqFFIPlugin.c -fPIC -DPIC -o .libs/sqFFIPlugin.o In file included from /home/runner/work/opensmalltalk-vm/opensmalltalk-vm/platforms/Cross/vm/sqMemoryAccess.h:23, from /home/runner/work/opensmalltalk-vm/opensmalltalk-vm/platforms/Cross/vm/sqVirtualMachine.h:30, from /home/runner/work/opensmalltalk-vm/opensmalltalk-vm/platforms/Cross/plugins/SqueakFFIPrims/sqFFIPlugin.c:22: /home/runner/work/opensmalltalk-vm/opensmalltalk-vm/building/linux64ARMv8/squeak.cog.spur/build.assert/config.h:40:2: error: #error This file was included too late. Please make sure it is included earlier

error This file was included too late. Please make sure it is included earlier

krono commented 1 year ago

Its https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c80633de4995150e366846fbfe8ef627793f4803 where the include is introduced.

edoneel commented 1 year ago

Thanks!!

On 2022-11-15T09:40:12.000+01:00, Tobias Pape @.***> wrote:

 Closed #659  [https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/659] as  completed via 1036378  [https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/10363780d28a7f8ca992c1bcd9a77cd03697dd6d].    —  Reply to this email directly, view it on GitHub  [https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/659#event-7811595900],  or unsubscribe  [https://github.com/notifications/unsubscribe-auth/ACEXJIQFLDUYTOUG3M2BVWTWIND6ZANCNFSM6AAAAAASAVJ3IQ].  You are receiving this because you authored the thread.Message ID: @.***>