OpenSmock / Pyramid

Pyramid is a Graphical User-Interface (GUI) builder and editor for Bloc and Toplo.
MIT License
29 stars 5 forks source link

Cannot compare ToTheme in the theme selector #169

Open labordep opened 1 month ago

labordep commented 1 month ago

Exception : NotFound: [ :each | each model = anItem ] not found in OrderedCollection when I'm trying to edit a Toplo view into Pyramid.

image

labordep commented 1 month ago

This is major because I cannot edit Toplo view with theme!

labordep commented 1 month ago

@plantec says that it should be better to ask the Theme class and not the Theme instance.

Nyan11 commented 1 month ago

It is true if we considere the theme as static. For example we do not dynamicly update token values

labordep commented 1 month ago

That's why I prefer to implement "=" in Themes :)

plantec commented 1 month ago

no = please. now, token properties can be added dynamically in a theme. @pierre, this is not that one should take the class. I said to store an instance in a class variable :)

labordep commented 1 month ago

We can display the class name of the current Theme in the list and propose to setup another one using just class name comparison. We can reset the current Theme (in case of modifications) by a new one from the same class.