We've been using this implementation in production for a few years now and wanted to share some of the improvements we've humbly made, based on our particular experience.
Since OpenSmpp.org encourages submitting pull request I took the liberty of forking and publishing our custom changes, prior authorization from my boss @cnlopezv.
This is our first organizational and personal collaboration ever, so please apologize me in case any unintended mistake was made.
The fixes in chronological order are:
f8cd1c0: Prevents NullPointerException when an ESME sends an empty message. Unfortunately NPE at this point prevents processing the DLR when reusing this class. This affected us quite often in the past.
be18230: When more than one interface is available it would be interesting to bind the service to one of them, due to compartmentalization considerations.
c6ea0aa: Changes the way timestamp is printed by FileLog class. Printing timestamp this way seems to be more obvious and transparent than trying to format it in a different manner.
I ran "mvn -X clean test" in order to validate the changes using oldest java version compatible. Latest version of Java 6SE failed with: "Exception in thread "main" java.lang.UnsupportedClassVersionError: org/apache/maven/cli/MavenCli : Unsupported major.minor version 51.0".
Finally, I am attaching log file that was generated in case of more information seems to be required: mvn_log.zip
Please feel free to contact me in case you have any questions or comments.
paoloc0
commented
5 years ago
Hi there!
This is Jorge with @Voissnet.
We've been using this implementation in production for a few years now and wanted to share some of the improvements we've humbly made, based on our particular experience.
Since OpenSmpp.org encourages submitting pull request I took the liberty of forking and publishing our custom changes, prior authorization from my boss @cnlopezv.
This is our first organizational and personal collaboration ever, so please apologize me in case any unintended mistake was made.
The fixes in chronological order are:
f8cd1c0: Prevents NullPointerException when an ESME sends an empty message. Unfortunately NPE at this point prevents processing the DLR when reusing this class. This affected us quite often in the past. be18230: When more than one interface is available it would be interesting to bind the service to one of them, due to compartmentalization considerations. c6ea0aa: Changes the way timestamp is printed by FileLog class. Printing timestamp this way seems to be more obvious and transparent than trying to format it in a different manner.
I ran "mvn -X clean test" in order to validate the changes using oldest java version compatible. Latest version of Java 6SE failed with: "Exception in thread "main" java.lang.UnsupportedClassVersionError: org/apache/maven/cli/MavenCli : Unsupported major.minor version 51.0".
Finally, I am attaching log file that was generated in case of more information seems to be required: mvn_log.zip
Please feel free to contact me in case you have any questions or comments.
Thank you in advance for your consideration.
Regards, Jorge.