Google and Facebook Login - Githubissues

OpenSocial / explorer

Tool to learn how to develop OpenSocial gadgets. #social

Apache License 2.0

34 stars 59 forks source link

Google and Facebook Login #63

Closed kehphin closed 11 years ago

kehphin commented 11 years ago

Implemented Google Login
Implemented Facebook Login
Fixed race condition bug in OpenID providers
Refactored and abstracted out code related to OpenID/ OAuth login

ryanjbaxter commented 11 years ago

Please make sure you add unit tests for new/changed code. Also please make sure you have JavaDoc for the new Java code

ryanjbaxter commented 11 years ago

I feel like both the Facebook and Google servlets still have a fair number of similarities that can be abstracted. Please see if you can abstract more of the code out from the two.

buildhive commented 11 years ago

OpenSocial Foundation » explorer #73 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

OpenSocial Foundation » explorer #75 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

OpenSocial Foundation » explorer #76 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

OpenSocial Foundation » explorer #77 SUCCESS This pull request looks good (what's this?)

ryanjbaxter commented 11 years ago

One more thing Kevin, can you provide some documentation on how to setup the Facebook and Google login options?

buildhive commented 11 years ago

OpenSocial Foundation » explorer #78 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

OpenSocial Foundation » explorer #79 SUCCESS This pull request looks good (what's this?)