search

OpenSouce-LNMIIT / JavaScriptProjects

This guide is intended for people looking to work on projects to get hands-on learning experience but out of ideas.
https://opensouce-lnmiit.github.io/JavaScriptProjects/
85 stars 46 forks source link

Virtual debit card #18

Closed viditvarshney closed 6 years ago

viditvarshney commented 6 years ago

THis is a web based project , this code generates a virtual debit card with name of yours and a CVV number on it ... the best part of this is .. CVV number changes every time when you run the code

viditvarshney commented 6 years ago

thanks 🙏

https://www.github.com/viditvarshney

On Sat, Sep 1, 2018, 3:19 PM Divyanshu Rawat notifications@github.com wrote:

@divyanshu-rawat approved this pull request.

LGTM!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cybros-LNMIIT/JavaScriptProjects/pull/18#pullrequestreview-151589306, or mute the thread https://github.com/notifications/unsubscribe-auth/Agk8ZSPZfcfAicK0gIQEvTUWHo0bSay6ks5uWlgbgaJpZM4WVn1n .

divyanshu-rawat commented 6 years ago

@Paarmita can you please review it 👍

viditvarshney commented 6 years ago

excuse me why my code is not merged yet?

divyanshu-rawat commented 6 years ago

@viditvarshney I have reviewed your code and it looks good to me, but it doesn't mean that it looks good to other contributors and community members as well. So, I am waiting for other community members to review it as well. Good Luck 👍

@yashovardhanagrawal, can you go through the code and review and see whether it's good to merge. 👍

theamanbhargava commented 6 years ago

Looks good to me too.