OpenSource-Tools / LiquidVoting

1 stars 0 forks source link

Change HTML for Add/remove interest (issue page) #24

Closed kvdmolen closed 9 years ago

kvdmolen commented 9 years ago

At: http://178.62.254.91/lf/issue/show/2.html

There's a button add my interest. Change the Add interest HTML from:

<div class="right">
  <form ...></form>
  <script type="text/javascript">...</script>
  <a class="btn btn-default" ...>add my interest</a>
</div>

to

<div class="btn-interest">
  <form ...></form>
  <script type="text/javascript">...</script>
  <i class="fa fa-bell-slash"></i><a class="" ...>Add interest</a>
</div>

(remove class from <a>)

And the Remove interest from:

<div class="right">
  <img class="icon48 right" src="../../static/icons/48/eye.png">You are interested in this issue<br>
  <form ...></form>
  <script type="text/javascript">...</script>
  <a ...>remove my interest</a>
</div>

to

<div class="btn-interest interested">
  <form ...></form>
  <script type="text/javascript">...</script>
  <i class="fa fa-bell"></i><a ...>Remove interest</a>
</div>
nktc commented 9 years ago

Added.

However, I think you had the fa-bell classes reversed. Let me know if that is not what you intended.

On Thu, Apr 9, 2015 at 4:35 AM, Klaas van der Molen < notifications@github.com> wrote:

At: http://178.62.254.91/lf/issue/show/2.html

There's a button add my interest. Change the Add interest HTML from:

to

(remove class from .

And the Remove interest from:

to

— Reply to this email directly or view it on GitHub https://github.com/Socioneers/LiquidVoting/issues/24.

kvdmolen commented 9 years ago

Nope, well, that means it's ambiguous. Please make both simply the fa-bell. I'll use a color to indicate status.

Also, (same as other remark) <i> tag is now a wrapper, but should just be <i></i> in front of <a> element (see HTML above)

Also, please add class .interested to .btn-interest when user is interested (see above)

Tnx!

nktc commented 9 years ago

Please re-open if not correct.

178.62.254.91/lf/issue/show/1.html