Email translations

[kvdmolen]

Translations in the notification email (Georgian language) still contains english words.

[nktc]

Georgian translations are defined here:

https://github.com/Socioneers/LiquidVoting/blob/master/frontend/locale/translations.ka.lua

There are hard-coded English phrases in several places - could you comment on which ones you want changed (perhaps all?) and what you would like the changes to be?

https://github.com/Socioneers/LiquidVoting/blob/master/frontend/model/event.lua#L83 https://github.com/Socioneers/LiquidVoting/blob/master/frontend/model/member.lua#L559 https://github.com/Socioneers/LiquidVoting/blob/master/frontend/app/main/index/_action/send_login.lua#L22 https://github.com/Socioneers/LiquidVoting/blob/master/frontend/app/main/index/_action/reset_password.lua#L22

I think the first two links are the notification emails you are referring to.

[kvdmolen]

I'll get back to this..

[kvdmolen]

My suggestion would be to add all of these hard-coded phrases to the end of the translations.en.lua file, that way we can see the newly added line-items.

We can then take care of the other non-english files afterwards.

Is this doable you think?

[nktc]

Actually I looked at how the locale stuff works again. It's a little subtle, which is why I didn't notice it at the first look. Here's some background:

_("phrase")

Looks up "phrase" in the appropriate translations.$LANG.lua file and replaces its contents -- the _ is a translation function call. Luckily I've seen this idiom before in other languages, or I might never have figured it out!

Anyway, the things I linked to above should be translated, if there are matching definitions in the respective translation files.

@kvdmolen you wrote

Translations in the notification email (Georgian language) still contains english words.

If you can provide a screenshot that would be super-helpful to tracking down what is going on here.

Thanks!