Closed kvdmolen closed 9 years ago
1-3 done, will return to 4.
Oho, code duplication again :(
Please also apply number 3 here: http://178.62.254.91/lf/unit/show/2.html
Updated.
I have updated 4 - please review and comment?
Ah, almost!
It seems again a mixup in Breadcrumb and Sidebar..
(this post)
The two .tab-sidebar-units
tabs in the sidebar (political party 1 + Central district) and the .row
below should get the <i>
thing, if delegated! Exactly like the .subscribed
class:
<div class="row subscribed">
<i class="fa fa-star tooltip"><span><span>You are subscribed</span></span></i>
<a href="../area/show/2.html" class="area">Economy</a>
</div>
So when also delegated, this becomes:
<div class="row subscribed delegated">
<i class="fa fa-star tooltip"><span><span>You are subscribed</span></span></i>
<i class="fa fa-hand-o-right tooltip"><span><span>{{"[You delegated this subject area] / [You delegated this unit]"}}</span></span></i>
<a href="../area/show/2.html" class="area">Economy</a>
</div>
(where i
not nested in a
, my bad).
Please notice this holds for the units (header) <div class="head">
and the area's (row) <div class="row">
The <i>
tag there is not required, I'll simply use css to place the icon, but will require the .delegated
class added.
Currently:
<li class="area">
<a href="../../area/show/2.html"><span>Economy</span></a>
<a href="../../area/"><i class="fa fa-hand-o-right tooltip"><span><span>You delegated this subject area</span></span></i></a>
</li>
can become (.delegated
class added, <i>
removed):
<li class="area delegated">
<a href="../../area/show/2.html"><span>Economy</span></a>
</li>
I believe these changes are all done. Please verify.
Thank you for the excellent documentation. It was easy to follow!
Perhaps some duplicate issues as #15, but better specified. See below for original HTML!
Changes
1
All elements directly under
will get this classed:
Instead of
2
.sidebar
class from all<div class="sidebar row">
.sidebar
class from all<div class="sidebar head">
3
At index page there is this sidebar-tab:
<div class="tab-whatcanido units">
under
<div class="sidebar row">
there is<img title="subscribed" alt="subscribed" class="icon16 star" src="../static/icons/48/star.png">
If this image exists, one is "subscribed" to that unit. Please:
<i class="fa fa-star tooltip"><span><span>{"You are subscribed"}</span></span></i>"
with this text-reference..subscribed
to the<div class="sidebar row">
So, with all three rules, it becomes:
4
Both the "Organisational Unit" and the "Subject Area" can be delegated.
An
<a>
tag will appear if it is delegated, including an image. The image should be removed, and replaced with an<i>
. The<img class="member_image ..
can be completely removed.This HTML appears at two places, both in
.head
and.row
(also see below):It changes to (text from here for subject Area (
.row
) and from here for Organisational Unit (.head
)):.delegated
to<div class="sidebar head">
.delegated
to<div class="sidebar row">
Original HTML: