OpenSourceAP / CrossSection

Code to accompany our paper Chen and Zimmermann (2020), "Open source cross-sectional asset pricing"
https://papers.ssrn.com/sol3/papers.cfm?abstract_id=3604626
GNU General Public License v2.0
714 stars 215 forks source link

Sin stocks #100

Closed tomz23 closed 1 year ago

tomz23 commented 1 year ago

Patrick Schwarz writes:

„In your code on GitHub (line 20 in Signalhorn.do) and also in the online appendix (page 25) you write that you assume as in the original paper that once a stock is classified as Sin, the entire past and the entire future is also considered Sin.

I read the Hong Paper as saying that there is no forward classification (forward filling) and only a look back (backward filling) for periods before 1985 due to lack of data.

The implementation with forward and backward filling contains thus nevertheless unnecessarily much noise, which seems unnecessary to me at least in relation to the forward filling. Also noteworthy is that Hong 2009 use the Fama French industry classification which is primarily based on historical COMPUSTAT SIC codes and it seems to me that your code is using historical CRSP SIC codes, which often times are different from the COMPUSTAT SIC codes.

tomz23 commented 1 year ago

Update here: https://github.com/OpenSourceAP/CrossSection/commit/53485730065edc6a6fa5caa573a3d261c15cae16