search

OpenSourceAP / CrossSection

Code to accompany our paper Chen and Zimmermann (2020), "Open source cross-sectional asset pricing"
https://papers.ssrn.com/sol3/papers.cfm?abstract_id=3604626
GNU General Public License v2.0
738 stars 218 forks source link

update ZJR_InputOutputMomentum.R filenames #99

Closed chenandrewy closed 1 year ago

chenandrewy commented 1 year ago

Christoph Reschenhofer writes:

I wanted you to know that I may have found a bug in one of the R-files for Datadownload. In Line 359 you grepl from the downloaded files. I think the name of the files changed. https://github.com/OpenSourceAP/CrossSection/blob/cabb77ffe949d41dfeefcde043e31bf39be1a0c4/Signals/Code/DataDownloads/ZJR_InputOutputMomentum.R#L359 However, providing “Supply_Tables_1997-2 …. “ in the grepl function resolves the issue. pathSupply = fls$Name[grepl("Supply_Tables_1997-2[0-9]{3}_sum.xlsx", fls$Name, ignore.case = TRUE)]

chenandrewy commented 1 year ago

Fixed here dec0f8dcd1fdec6c09d6a669fe331f3e577aebed