search

OpenSourceBrain / OSBv2

An updated version of the Open Source Brain platform
https://www.v2.opensourcebrain.org/
Other
11 stars 6 forks source link

Update nwb explorer links #795

Closed filippomc closed 10 months ago

filippomc commented 10 months ago

Now http://nwbexplorer.opensourcebrain.org/hub/nwbfile, should be http://nwbexplorer.opensourcebrain.org/?nwbfile=...

pgleeson commented 10 months ago

DANDI Archive have been told in the past to use a link of the form (which used to but no longer works): http://nwbexplorer.opensourcebrain.org/nwbfile=https://dandiarchive.s3.amazonaws.com/blobs/724/0a5/7240a588-db87-4526-8223-cb43b4bea092

Can this not be still supported without requiring them (and others) to update their urls?

filippomc commented 10 months ago

The above link is not syntactically correct, not sure where it's been taken from. Should be ?nwbfile=

pgleeson commented 10 months ago

Hopefully this line is all that will need to change to fix it on their side... https://github.com/dandi/dandi-archive/blob/b38aa93ed9162c05ba95edfac7d0b9cba40a5ff0/web/src/views/FileBrowserView/FileBrowser.vue#L319

pgleeson commented 10 months ago

@filippomc This (with slash as you suggest): http://nwbexplorer.opensourcebrain.org/?nwbfile=https://github.com/openworm/WormsenseLab_ASH/raw/main/test_data/07-06-25-1.nwb goes to the hub page at https://nwbexplorer.v2.opensourcebrain.org/hub/home

This (no slash) http://nwbexplorer.opensourcebrain.org?nwbfile=https://github.com/openworm/WormsenseLab_ASH/raw/main/test_data/07-06-25-1.nwb fails initially, by going to nwbe homepage, then if url is put into same tab again, works sometimes...

filippomc commented 10 months ago

The version without ? works on dev https://nwbexplorer.v2dev.opensourcebrain.org/nwbfile=https://github.com/openworm/WormsenseLab_ASH/raw/main/test_data/07-06-25-1.nwb

Still it's true that doesn't work on first try, will fix that

pgleeson commented 10 months ago

Thanks. FYI issues with plotting any trace (clicking on eye):

Screenshot 2023-11-10 at 09 35 52
filippomc commented 10 months ago

fixed

pgleeson commented 10 months ago

@filippomc Do you mean it's fixed on dev or live? For live, now both the urls above (with and without slash) now go to the hub. On dev, the link works, but the plots don't show...

filippomc commented 10 months ago

Right, the fixed version of NWB explorer wasn't deployed on v2dev yet. Nothing has been changed on live.

pgleeson commented 10 months ago

Closing as the preferred form is working. Need to update DANDI links...

pgleeson commented 10 months ago

See https://github.com/dandi/dandi-archive/pull/1755 for DANDI url update status