search

OpenSourceBrain / OSBv2

An updated version of the Open Source Brain platform
https://www.v2.opensourcebrain.org/
Other
11 stars 6 forks source link

Workspace filter: "create your first workspace" dialog is shown if filter returns no results, even if I already have workspaces #866

Open sanjayankur31 opened 9 months ago

sanjayankur31 commented 9 months ago

osbv2-live-workspace-search

I have lots of workspaces already. I was trying to find one but didn't use the right search. So the search result has 0 results. However, it should not say "create your first workspace"---that should only be said if the user has no workspace. This should maybe say "no workspaces found, create a new one" or something like that.

pgleeson commented 9 months ago

https://github.com/OpenSourceBrain/OSBv2/blob/dd540890003bfa2c30d3cf11076042d0fa9d811b/applications/osb-portal/src/pages/WorkspacesPage.tsx#L290

sanjayankur31 commented 9 months ago

It'll need some logic there to distinguish between "user has no workspaces" and "no workspaces were returned in the search".