search

OpenSourceBrain / redmine

This is a customised version of redmine for the Open Source Brain website
http://www.opensourcebrain.org
5 stars 3 forks source link

ACNet2 example broken #301

Closed borismarin closed 7 years ago

borismarin commented 7 years ago

I'm getting an empty geppetto session when trying to load ACNet2 (from an incognito window - thus no cache):

screen shot 2017-08-18 at 13 42 53

See error in js log; also check https://github.com/openworm/org.geppetto/issues/573

pgleeson commented 7 years ago

Have restarted the server. Works for me now. Retry?

borismarin commented 7 years ago

Nope, still broken - same error:

screen shot 2017-08-18 at 14 12 56
pgleeson commented 7 years ago

It worked first time in Firefox, then it gave the error above in Chrome, but network appeared fine when I reloaded.

borismarin commented 7 years ago
mattearnshaw commented 7 years ago

thanks. looking in to this now...

mattearnshaw commented 7 years ago

haven't been able to figure out why the 3D view doesn't appear when loading for the first time with no cache, but the error about network_ACnet2.baskets_12[0].soma_0.v should be fixed at least. @pgleeson I will keep looking into this a bit tomorrow so things are OK for Sunday

mattearnshaw commented 7 years ago

The problem is the camera position is not set correctly. For Canvas1, we end up at here, and then component is undefined at L91 and setView is never called. Why this only happens once, must be a timing issue caused by caching. The TODO at L87 in ViewController should probably be filled in, but I can try calling applyView from the canvas addComponent callback in geppetto-osb for now.

tarelli commented 7 years ago

@mattearnshaw thanks for looking into this, if you find a fix for frontend I can also patch the release. I'll be travelling in the next days so I probably won't have time to provide a fix myself. @gidili can also help you navigate what's happening with the views there.

mattearnshaw commented 7 years ago

will get something better next week, but hack @ https://github.com/OpenSourceBrain/geppetto-osb/commit/963a8d33181b6fbf7ff27db74949991c4406879f has fixed this on osb.org, ahead of INCF meeting

mattearnshaw commented 7 years ago

fixed at https://github.com/openworm/org.geppetto.frontend/commit/10c5bc2e5b608ddc1c5485bac38926cb6b0f3966

see discussion at https://github.com/OpenSourceBrain/geppetto-osb/commit/963a8d33181b6fbf7ff27db74949991c4406879f#commitcomment-23766707