Add files via upload - Githubissues

OpenSourceEBike / Bafang_M500_M600

GNU General Public License v3.0

86 stars 37 forks source link

Add files via upload #4

Closed CiDi-IT closed 3 years ago

CiDi-IT commented 3 years ago

This is the modified version of the python file to have full access even with the latest version of BESST

CiDi-IT commented 3 years ago

With the version of BESST 1.2.26, I had to make these changes, otherwise you don't have access to the settings.

PrivatePuffin commented 3 years ago

Shoot my PC is tripping it... sorry for the random close.

PrivatePuffin commented 3 years ago

With the version of BESST 1.2.26, I had to make these changes, otherwise you don't have access to the settings.

Could you explain which change you refer to?

It looks you're quite new to GIT...

With a PR, it's normal to explain in the title what you are changing with a few words (so not 'add files via upload')
It's also important to describe in the description in more detail what the changes are and why these changes are required
It's also not really appreciated to change all lineendings in a file, which seems to have been done, as it makes the diff an absolute mess.

PrivatePuffin commented 3 years ago

With changes I think you mean 'status':1 to 'status':6?

CiDi-IT commented 3 years ago

Sorry, I actually don't know Github that well. I have not modified your file, but I uploaded a new one that I had modified in February, maybe I was wrong to give it the same name.

I know the Bafang M600 quite well, I'm the one who invented the system via the Can innomaker interface

PrivatePuffin commented 3 years ago

Sorry, I actually don't know Github that well. I have not modified your file, but I uploaded a new one that I had modified in February, maybe I was wrong to give it the same name.

I know the Bafang M600 quite well, I'm the one who invented the system via the Can innomaker interface

Did you test our version at all, or did you just asume you should replace what we've done with your version from february?

It's assumed kinda rude to revert improvements other people have made with work from months ago, unless a bug got introduced with the improvements...

So what I'm trying to find out: What do you want changed? Normally you do not completely replace files on Github, you change them.

PrivatePuffin commented 3 years ago

Closing, because this PR has severe form errors and it's not clear what this user wants to accomplice with the PR.

CiDi-IT commented 3 years ago

Sorry, I'm not familiar with github procedures, I'll remember it for next time. I have tested the file and it does not let me access the BESST program in constructor mode, tomorrow I will do further tests.

PrivatePuffin commented 3 years ago

I'm going to merge this just to be sure, as it cannot hurt either! :)