OpenSourceEBike / Color_LCD

21 stars 9 forks source link

Made street mode display more verbose, moved assist level a bit right #95

Closed bhelm closed 4 years ago

bhelm commented 4 years ago

After having some confusion about the street mode state (see #93) i decided to change it so it is clear which mode is active without consulting the manual. The orange color was also a bit harder to read in sunlight.

Also placed the assist level display a bit more to the center, or is there something that would overlap?

casainho commented 4 years ago

I was looking and I don't like ASSIST STREET and ASSIST FULL words. I prefer something more graphical and I understand that only changing color may not be enough. If i had time, I would try to invert the assist level, like put at with background and black colors both the text ASSIST and the assist number and background.

On SW102, I am drawing a square around but maybe the invert colors would be even better.

bhelm commented 4 years ago

My goal was to make the street mode state intuitive understandable so there is no need to read the manual to know when it is active. I think there are two kinds of users of the firmware: the ones that build the bike, flash it and (hopefully) read the manual and the ones that just got to ride the bike without much introduction. Having an UI that speaks for itself is a good thing for everyone.

how about a small street symbol when the street mode is active? that symbol could also be ported over to SW102 if there is space somewhere (but i have none to test). something like this (excuse my paint skills): grafik

i would place it left to the assist level, so that another symbol would fit below.

casainho commented 4 years ago

I do not want to change current design. On the SW102 the logic was to make the assist level and wheel speed field inside a box when power and speed are limited and no box when there are no limitations. OK, I think a box could be draw on the rectangle that has the assist level and wheel speed, like lines of 2px because current lines are 1px.

I do not want to make easy to understand on display that user in one specific mode, because no one inspecting the display should understand this. On other ebikes, you enable offroad mode with brakes only sequence and nothing shows on the display, on purpose.

bhelm commented 4 years ago

so it was intentional to have an unobtrusive surface for street mode, ok thats fine (closing).

although I do not fully understand the reason. If someone wants to find out if the bike is street legal or not, he will probably do it with a test ride instead of looking at the display.