OpenSourceEBike / TSDZ2_wireless

TSDZ2_wireless
36 stars 11 forks source link

Remote unresponsive #65

Open casainho opened 3 years ago

casainho commented 3 years ago

I do not know how to replicate but did happen 3 times to me. I think is when I decrement a few times in sequence and then there is no response (no blink from any button).

@rananna

casainho commented 3 years ago

I tested again, seems an issue easy to replicate: change assist level when motor is turned off.

rananna commented 3 years ago

sorry, I do not understand. Per your request, the remote currently does NOT change assist level when the motor is off. It simply flashes red.

rananna commented 3 years ago

I will try to see if I can do something more about interrupt priority for GPIO so that button presses are not missed. As discussed previously, this is a known Nordic issue when using a softdevice. The softdevice has the highest priority, and if it is still processing communication events it locks out the button interrupt. Any button press that is captured is setting the assist level though, there is no missing assists no matter how may up/down combinations are made.

rananna commented 3 years ago

When I press the button quickly with the motor off, I do not see any missing red flashes. Is that what you are referring to?

rananna commented 3 years ago

And, are you using the latest firmware for the remote? I made the interrupt priority and assist capture changes only recently. I am not seeing any issue with the motor on also

rananna commented 3 years ago

button high accuracy mode can improve responsiveness, but has a BIG power impact. I don't think we want this.

rananna commented 3 years ago

OK, I think this has been addressed. Please check with my FEB 7 PR