search

OpenSourceEBike / TSDZ2_wireless

TSDZ2_wireless
35 stars 11 forks source link

led alerts from common_firmware #81

Closed 4var1 closed 3 years ago

4var1 commented 3 years ago

I fixed the brightness issue - all levels should work - and highest brightness is brighter!

I've commented disp_soc() from ledalerts as it wasn't really the place for it imho. I'm happy to create a common utils.c/h if necessary that we can put stuff that we want to share in - but to indulge my ocd can we keep disp_soc out of ledalert please :)

I also changed the assist_limit sequence back as it really affected useability having the three flash sequence rather than a single quick flash - as it was longer than a button press and so made it look laggy.

I feel less strongly about motor on - but I did change it back. New change had it so the led was on for 200ms then off for only 50. I had it on for 200/off for 200 - so running the led a lot less... Plus it matches the cadence of the following sequence... Change back if you feel strongly about it!

Right - time for a beer - hopefully all should be ok now. Cheers!

rananna commented 3 years ago

you have been busy while I was out! I will merge the changes and see how it performs with the wireless remote. However, I cant get to it until tomorrow.