search

OpenSourceEBike / TSDZ2_wireless

TSDZ2_wireless
35 stars 11 forks source link

Led signalling works well #82

Closed rananna closed 3 years ago

rananna commented 3 years ago

@casainho , I have incorporated the latest changes from @4var1 and tested all modes of operation for the wireless remote It works well, and I have updated the docs.(see PR there) Notes:

  1. the count for SOC was wrong -fixed.
  2. Added ability to set intensity level through double click (see docs)
  3. added ability to enter hibernate mode through double click (see docs)

Please give it a try on your bike, and if it tests out well we could issue a new release.

casainho commented 3 years ago

Why do you keep updating the documentation on this repo as also on the main site http://opensourceebike.github.io/ ?

rananna commented 3 years ago

I thought you wanted to have the more detailed developer docs in the code repo, and the simplified docs in the docs repo. I have instructions on how to use in both locations.

casainho commented 3 years ago

So if I understand correctly, the how to use instructions are duplicated - and as user, everyone should look at only one place. So please save your time and do not do it next time :-)

Also on the https://opensourceebike.github.io/ you are keeping adding the BACK fixed link at the end of the page. That is also a bad practice as you can not guarantee that will return to correct previous page as that page it self can be linked from different places - that is why there is the internet browser back button as also Android back button. So save your time and do not add the BACK at the end of the page.

rananna commented 3 years ago

I was unsure how it works on Apple devices, so I added the back button. Will remove.