OpenSourceEBike / TSDZ2_wireless

TSDZ2_wireless
36 stars 11 forks source link

Wired Remote Schematic v0.1 #96

Closed 4var1 closed 3 years ago

rananna commented 3 years ago

@4var1 , I have changed the wireless remote to use the new signalling functions. However there is an issue. When I tried to replace led_clear_queue () (used to stop a currently playing sequence) with led_clear_queue_and_stop_current_sequence(), the led remains lit instead of turning off.

4var1 commented 3 years ago

@4var1 , I have changed the wireless remote to use the new signalling functions. However there is an issue. When I tried to replace led_clear_queue () (used to stop a currently playing sequence) with led_clear_queue_and_stop_current_sequence(), the led remains lit instead of turning off.

Hi - thanks for updating - but am a bit confused as that isn't one of the new calls exposed in the header? I'm off out now - will be back a bit later but try using the ones in the header only.

rananna commented 3 years ago

but which one? led_clear_queue works fine, but you didn't want me to use it. What should I replace it with?

4var1 commented 3 years ago

The ones in the header - just under the old ones - and above the ones you put back. You don't need to call the queue mgmt directly - use the specific calls - like play_sequence_next (replaces clear queue/led_alert) - the comments tell you what's what...

rananna commented 3 years ago

I did that, please see first comment.

4var1 commented 3 years ago

In your first comment you reference a call that isn't defined in the header, no?