search

OpenSourceEBike / ebike_wireless_remote

ANT+ remote button
10 stars 8 forks source link

set up configuration flash flags for ANT LEV and ANT control #24

Closed rananna closed 3 years ago

rananna commented 3 years ago

@casainho, I added flags into a flash configuration file for ANT LEV and ANT controls as I proposed earlier today.

This PR is configured as follows: 0x90 - turn ANT LEV control on 0x91 - turn ANT LEV control off 0x92 - turn ANT CONTROL on 0x93 - turn ANT CONTROL off anything else - change ant ID

I just saw your comment on using MSB for ANT ID and LSB for flag setting. I can certainly implement this way, but it adds complexity for the average user to figure out how to construct a 2 byte integer properly. They would need an app to figure this out.

please add this PR for now as it cleans up the ANT code, and let me know if you want me to implement the MSB/LSB approach If so, I can add it and give you another PR.

btw, the changes to the makefile to eliminate the bootloader include are not working for me. How is it supposed to function, and what do I need to do to get it working?

stsdc commented 3 years ago

@rananna what is not working? please be more specific, what errors do You have etc

rananna commented 3 years ago

Well, as I am not familiar with GitHub actions, I am not sure what is supposed to be happening. The make file fails to build as I showed earlier today. The bootloader directory is empty. Is it supposed to auto populate? I get emails that say: OpenSource-EBike-firmware/ebike_wireless_remote] Lint workflow run

  

Lint: All jobs have failed

 View workflow run

And

OpenSource-EBike-firmware/ebike_wireless_remote] Build workflow run

  

Build: All jobs have failed

 View workflow run  Build / build Failed in 2 minutes and 10 seconds  1 

So it is hard to give more specifics as I don't understand what you are trying to accomplish.

stsdc commented 3 years ago

You can exactly see why CI fails here. obraz It is #9.