search

OpenSourceEconomics / grmpy

Python package for the simulation and estimation of generalized Roy model
http://grmpy.readthedocs.io
MIT License
19 stars 5 forks source link

Merge sebecker in develop #137

Closed SeBecker closed 6 years ago

SeBecker commented 6 years ago

This change is Reviewable

codecov-io commented 6 years ago

Codecov Report

Merging #137 into develop will decrease coverage by 0.68%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #137      +/-   ##
===========================================
- Coverage    96.95%   96.27%   -0.69%     
===========================================
  Files           16       17       +1     
  Lines         1478     1502      +24     
===========================================
+ Hits          1433     1446      +13     
- Misses          45       56      +11
Impacted Files Coverage Δ
grmpy/test/random_init.py 98.79% <ø> (-0.01%) :arrow_down:
grmpy/check/check.py 100% <ø> (ø) :arrow_up:
grmpy/test/auxiliary.py 73.43% <ø> (-6.23%) :arrow_down:
grmpy/simulate/simulate_auxiliary.py 99.34% <ø> (ø) :arrow_up:
grmpy/estimate/estimate_auxiliary.py 97.4% <ø> (ø) :arrow_up:
grmpy/test/test_unit.py 96.01% <ø> (+0.08%) :arrow_up:
grmpy/test/test_integration.py 100% <ø> (ø) :arrow_up:
grmpy/test/resources/tutorial.py 0% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf8f666...3f9193d. Read the comment docs.

peisenha commented 6 years ago

Reviewed 202 of 218 files at r9, 23 of 23 files at r10. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable