search

OpenSourceEconomics / grmpy

Python package for the simulation and estimation of generalized Roy model
http://grmpy.readthedocs.io
MIT License
19 stars 5 forks source link

code review #140

Closed peisenha closed 6 years ago

peisenha commented 6 years ago

Some edits, please review and address the TODO's in the code.

This change is Reviewable

codecov-io commented 6 years ago

Codecov Report

Merging #140 into develop will increase coverage by <.01%. The diff coverage is 91.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #140      +/-   ##
===========================================
+ Coverage    96.27%   96.27%   +<.01%     
===========================================
  Files           17       18       +1     
  Lines         1502     1504       +2     
===========================================
+ Hits          1446     1448       +2     
  Misses          56       56
Impacted Files Coverage Δ
grmpy/test/random_init.py 98.79% <ø> (ø) :arrow_up:
grmpy/read/read_auxiliary.py 97.1% <ø> (ø) :arrow_up:
grmpy/simulate/simulate_auxiliary.py 99.33% <ø> (-0.01%) :arrow_down:
grmpy/test/test_unit.py 95.97% <100%> (-0.05%) :arrow_down:
grmpy/check/auxiliary.py 100% <100%> (ø) :arrow_up:
grmpy/check/check.py 100% <100%> (ø) :arrow_up:
grmpy/estimate/estimate_auxiliary.py 97.14% <100%> (-0.26%) :arrow_down:
grmpy/grmpy_config.py 100% <100%> (ø)
grmpy/test/test_integration.py 100% <100%> (ø) :arrow_up:
grmpy/test/auxiliary.py 73.84% <50%> (+0.4%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b68b169...25a09a2. Read the comment docs.