OpenSourceEconomics / grmpy

Python package for the simulation and estimation of generalized Roy model
http://grmpy.readthedocs.io
MIT License
19 stars 5 forks source link

Code Review #152

Closed SeBecker closed 6 years ago

SeBecker commented 6 years ago

This pull request will enable us to comment the full code of the package.


This change is Reviewable

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (code_review@708dd64). Click here to learn what that means. The diff coverage is 95.88%.

Impacted file tree graph

@@              Coverage Diff               @@
##             code_review     #152   +/-   ##
==============================================
  Coverage               ?   95.88%           
==============================================
  Files                  ?       20           
  Lines                  ?     1676           
  Branches               ?        0           
==============================================
  Hits                   ?     1607           
  Misses                 ?       69           
  Partials               ?        0
Impacted Files Coverage Δ
grmpy/__version__.py 0% <0%> (ø)
grmpy/test/resources/tutorial.py 0% <0%> (ø)
grmpy/test/test_integration.py 100% <100%> (ø)
grmpy/grmpy_config.py 100% <100%> (ø)
grmpy/check/auxiliary.py 100% <100%> (ø)
grmpy/simulate/simulate.py 100% <100%> (ø)
grmpy/test/conftest.py 100% <100%> (ø)
grmpy/__init__.py 63.63% <63.63%> (ø)
grmpy/test/test_quality.py 70.58% <70.58%> (ø)
grmpy/test/auxiliary.py 77.27% <77.27%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 708dd64...e93a90a. Read the comment docs.