search

OpenSourceEconomics / grmpy

Python package for the simulation and estimation of generalized Roy model
http://grmpy.readthedocs.io
MIT License
19 stars 5 forks source link

Improving the performance of *grmpy*'s estimation process #171

Closed SeBecker closed 5 years ago

SeBecker commented 5 years ago

Problem The current version of our estimation process in the master branch does not work as efficient as intended.

Solution The current version processes the data almost completely as pandas dataframe objects. Replacing the data handling as well as the processing methods with numpy objects/operations will improve the performance significantly.

This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

Merging #171 into master will increase coverage by 0.03%. The diff coverage is 97.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   96.01%   96.04%   +0.03%     
==========================================
  Files          20       20              
  Lines        1379     1390      +11     
==========================================
+ Hits         1324     1335      +11     
  Misses         55       55
Impacted Files Coverage Δ
grmpy/__version__.py 0% <0%> (ø) :arrow_up:
grmpy/test/resources/tutorial.py 0% <0%> (ø) :arrow_up:
grmpy/check/custom_exceptions.py 80% <0%> (ø) :arrow_up:
grmpy/test/test_quality.py 70.58% <100%> (ø) :arrow_up:
grmpy/estimate/estimate_auxiliary.py 99% <100%> (-0.01%) :arrow_down:
grmpy/estimate/estimate.py 97.91% <100%> (+0.13%) :arrow_up:
grmpy/grmpy_config.py 93.75% <100%> (ø) :arrow_up:
grmpy/check/auxiliary.py 100% <100%> (ø) :arrow_up:
grmpy/read/read_auxiliary.py 100% <100%> (ø) :arrow_up:
grmpy/simulate/simulate.py 100% <100%> (ø) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fd1dad...0baeaab. Read the comment docs.