search

OpenSourceEconomics / grmpy

Python package for the simulation and estimation of generalized Roy model
http://grmpy.readthedocs.io
MIT License
19 stars 5 forks source link

Introducing the simulation of unobservables via multivariate gumbel and logistic distributions #175

Closed luward closed 4 years ago

luward commented 5 years ago

This change is Reviewable

SeBecker commented 5 years ago

grmpy/read/read_auxiliary.py, line 51 at r1 (raw file):

init_dict["DIST"]["dist"] = "normal" Maybe we should relabel this subkey to "type"?

SeBecker commented 5 years ago

grmpy/estimate/estimate_output.py, line 256 at r1 (raw file):

        # a multivariate normal distribution for the unobservables
        estm = 0
        U = simulate_unobservables(dict_, estm)

Please use a default value instead of defining a new variable.