Closed SeBecker closed 6 years ago
Merging #86 into master will decrease coverage by
3.27%
. The diff coverage is92.6%
.
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 96.46% 93.18% -3.28%
==========================================
Files 10 17 +7
Lines 537 1130 +593
==========================================
+ Hits 518 1053 +535
- Misses 19 77 +58
Impacted Files | Coverage Δ | |
---|---|---|
grmpy/test/test_integration.py | 100% <100%> (+3.33%) |
:arrow_up: |
grmpy/read/read.py | 100% <100%> (ø) |
:arrow_up: |
grmpy/test/test_unit.py | 100% <100%> (ø) |
:arrow_up: |
grmpy/test/conftest.py | 100% <100%> (+25%) |
:arrow_up: |
grmpy/estimate/estimate.py | 100% <100%> (ø) |
|
grmpy/__init__.py | 50% <100%> (+12.5%) |
:arrow_up: |
grmpy/simulate/simulate.py | 100% <100%> (ø) |
:arrow_up: |
grmpy/read/read_auxiliary.py | 85.48% <57.14%> (-2.45%) |
:arrow_down: |
grmpy/check/check.py | 59.09% <59.09%> (ø) |
|
grmpy/check/custom_exceptions.py | 60% <60%> (ø) |
|
... and 13 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c35da2...d7607ee. Read the comment docs.
Reviewed 41 of 41 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
Thanks for setting this up, please review the manual conflicts .... https://github.com/grmToolbox/grmpy/pull/86 Let me know if you need any help.
On Wed, Nov 29, 2017 at 3:39 PM, Codecov notifications@github.com wrote:
Codecov https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=h1 Report
Merging #86 https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=desc into master https://codecov.io/gh/grmToolbox/grmpy/commit/6c35da28ffd3a7dc18bec5d2a181539b4f57650e?src=pr&el=desc will decrease coverage by 3.27%. The diff coverage is 92.6%.
[image: Impacted file tree graph] https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree
@@ Coverage Diff @@## master #86 +/- ## ==========================================- Coverage 96.46% 93.18% -3.28%
Files 10 17 +7 Lines 537 1130 +593 ==========================================+ Hits 518 1053 +535 - Misses 19 77 +58
Impacted Files https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree Coverage Δ grmpy/read/read.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvcmVhZC9yZWFkLnB5 100% <100%> (ø) ⬆️ grmpy/test/test_integration.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvdGVzdC90ZXN0X2ludGVncmF0aW9uLnB5 100% <100%> (+3.33%) ⬆️ grmpy/test/test_unit.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvdGVzdC90ZXN0X3VuaXQucHk= 100% <100%> (ø) ⬆️ grmpy/simulate/simulate.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvc2ltdWxhdGUvc2ltdWxhdGUucHk= 100% <100%> (ø) ⬆️ grmpy/init.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvX19pbml0X18ucHk= 50% <100%> (+12.5%) ⬆️ grmpy/estimate/estimate.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvZXN0aW1hdGUvZXN0aW1hdGUucHk= 100% <100%> (ø) grmpy/test/conftest.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvdGVzdC9jb25mdGVzdC5weQ== 100% <100%> (+25%) ⬆️ grmpy/read/read_auxiliary.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvcmVhZC9yZWFkX2F1eGlsaWFyeS5weQ== 85.48% <57.14%> (-2.45%) ⬇️ grmpy/check/check.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvY2hlY2svY2hlY2sucHk= 59.09% <59.09%> (ø) grmpy/check/custom_exceptions.py https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree#diff-Z3JtcHkvY2hlY2svY3VzdG9tX2V4Y2VwdGlvbnMucHk= 60% <60%> (ø) ... and 13 more https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=tree-more
Continue to review full report at Codecov https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=continue.
Legend - Click here to learn more https://docs.codecov.io/docs/codecov-delta Δ = absolute
(impact), ø = not affected, ? = missing data Powered by Codecov https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=footer. Last update 6c35da2...5d79848 https://codecov.io/gh/grmToolbox/grmpy/pull/86?src=pr&el=lastupdated. Read the comment docs https://docs.codecov.io/docs/pull-request-comments . — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/grmToolbox/grmpy/pull/86#issuecomment-347879605, or mute the thread https://github.com/notifications/unsubscribe-auth/ADcMJ1dRItUnRi3hCDQuNgm4WHOit3M7ks5s7WyUgaJpZM4QvCqT .
-- Philipp Eisenhauer Economist
Mail eisenhauer@policy-lab.org Web www.eisenhauer.io Repository https://github.com/peisenha
This change is