OpenSourceEconomics / respy

Framework for the simulation and estimation of some finite-horizon discrete choice dynamic programming models.
http://respy.readthedocs.io
MIT License
77 stars 33 forks source link

Fix shocks in simulated data #414

Closed amageh closed 3 years ago

amageh commented 3 years ago

This PR fixes a bug in simulate which only adds untransformed shocks to df. Changes listed below:

Todo

codecov[bot] commented 3 years ago

Codecov Report

Merging #414 (7b3b560) into main (9a009af) will decrease coverage by 0.00%. The diff coverage is 84.37%.

:exclamation: Current head 7b3b560 differs from pull request most recent head 4b5a83e. Consider uploading reports for the commit 4b5a83e to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   87.48%   87.47%   -0.01%     
==========================================
  Files          50       50              
  Lines        3636     3658      +22     
==========================================
+ Hits         3181     3200      +19     
- Misses        455      458       +3     
Flag Coverage Δ
end_to_end 74.02% <59.37%> (-0.15%) :arrow_down:
integration 63.80% <40.62%> (-0.28%) :arrow_down:
unit 72.47% <78.12%> (+0.11%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
respy/method_of_simulated_moments.py 82.30% <33.33%> (-1.49%) :arrow_down:
respy/config.py 92.30% <60.00%> (-7.70%) :arrow_down:
respy/shared.py 84.03% <88.88%> (+0.55%) :arrow_up:
docs/conf.py 100.00% <100.00%> (ø)
respy/__init__.py 93.33% <100.00%> (ø)
respy/simulate.py 95.72% <100.00%> (+0.01%) :arrow_up:
respy/tests/test_simulate.py 100.00% <100.00%> (ø)
respy/tests/test_solve.py 99.55% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a009af...4b5a83e. Read the comment docs.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB